Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Allow the Elasticsearch Authorization using API Key #1019

Merged
merged 4 commits into from
Nov 9, 2024

Conversation

rohilla-anuj
Copy link
Collaborator

Made the following changes:

  • Allow users to authorise using API Key
  • Skip the data write step if the dataframe is empty
  • Add link to template medium articles
  • Fix the typos in the template Readme file

@rohilla-anuj rohilla-anuj changed the title feat!: Allow the Elasticseach Authorization using API Key feat!: Allow the Elasticsearch Authorization using API Key Nov 8, 2024
Copy link
Collaborator

@surjits254 surjits254 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@surjits254
Copy link
Collaborator

can you please rebase with main branch?

@rajc242 rajc242 added enhancement New feature or request python labels Nov 9, 2024
@rajc242 rajc242 merged commit 4ecbfa6 into main Nov 9, 2024
9 checks passed
@rajc242 rajc242 deleted the feature/ES_Template_Updates branch November 9, 2024 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants