Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate off go-tpm-tools' attest.proto usage #14

Open
alexmwu opened this issue Jan 13, 2025 · 0 comments
Open

Migrate off go-tpm-tools' attest.proto usage #14

alexmwu opened this issue Jan 13, 2025 · 0 comments
Assignees

Comments

@alexmwu
Copy link
Collaborator

alexmwu commented Jan 13, 2025

VerifiedCOSState depends on go-tpm-tools attest.proto for the AttestedCosState proto. This is fine for now, but we'd ideally like to have this library vend its own proto that are updated locally.

pb "github.com/google/go-tpm-tools/proto/attest"

Consider renaming the func and proto to have the same name like AttestedCOSState, VerifiedCOSState or ConfidentialSpaceState.

Additionally, VerifiedCOSState's signature is VerifiedCOSState(event_log cel.CEL, registerType uint8). It should instead take a cel.MRType from https://github.com/google/go-eventlog/blob/main/cel/canonical_eventlog.go#L21 as follows VerifiedCOSState(event_log cel.CEL, registerType cel.MRType)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants