Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for Python 3.12 #905

Merged
merged 10 commits into from
Jan 29, 2024
Merged

feat: add support for Python 3.12 #905

merged 10 commits into from
Jan 29, 2024

Conversation

jackwotherspoon
Copy link
Collaborator

Add that Python Connector officially supports Python 3.12

Closes #900

@jackwotherspoon jackwotherspoon self-assigned this Nov 16, 2023
@jackwotherspoon
Copy link
Collaborator Author

Python 3.12 no longer comes with setuptools (i.e pkg_resources) as mentioned in https://docs.python.org/3/whatsnew/3.12.html

This causes issues with pytds driver that imports pkg_resources in its __init__.py

.nox\system-3-12\Lib\site-packages\pytds\__init__.py:69: in <module>
    import pkg_resources  # type: ignore # fix later
E   ModuleNotFoundError: No module named 'pkg_resources'

Opened denisenkom/pytds#157 PR as a potential fix.

@jackwotherspoon jackwotherspoon marked this pull request as ready for review December 18, 2023 16:06
@jackwotherspoon jackwotherspoon requested a review from a team as a code owner December 18, 2023 16:06
@jackwotherspoon
Copy link
Collaborator Author

python-tds PR has been merged, should wait till release of 1.15.0 next month prior to merging this PR

Copy link
Member

@enocom enocom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a note about pytds? Probably not?

@jackwotherspoon
Copy link
Collaborator Author

Do we need to add a note about pytds? Probably not?

@enocom No we will just wait till the new release of pytds driver and the version bump in this repo should then make these builds green.

@jackwotherspoon jackwotherspoon merged commit 7501d17 into main Jan 29, 2024
15 checks passed
@jackwotherspoon jackwotherspoon deleted the python-3.12 branch January 29, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.12
2 participants