Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add arg for specifying credentials #226

Merged
merged 10 commits into from
Jan 4, 2022
Merged

feat: add arg for specifying credentials #226

merged 10 commits into from
Jan 4, 2022

Conversation

jackwotherspoon
Copy link
Collaborator

No description provided.

@jackwotherspoon jackwotherspoon self-assigned this Dec 21, 2021
kurtisvg
kurtisvg suggested changes Dec 22, 2021
View reviewed changes
google/cloud/sql/connector/connector.py Outdated Show resolved Hide resolved
google/cloud/sql/connector/instance_connection_manager.py Outdated Show resolved Hide resolved
@jackwotherspoon jackwotherspoon linked an issue Dec 29, 2021 that may be closed by this pull request
Adding support for service account credentials #171
Closed
@kurtisvg kurtisvg changed the title feat: support service account credentials in Connector object feat: add arg for specifying credentials Dec 29, 2021
@jackwotherspoon jackwotherspoon merged commit 85f5476 into main Jan 4, 2022
@jackwotherspoon jackwotherspoon deleted the support-service-accounts branch January 4, 2022 14:07
@gunar gunar mentioned this pull request Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@jackwotherspoon jackwotherspoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adding support for service account credentials
2 participants
@jackwotherspoon @kurtisvg