feat: Native image support for R2DBC driver #715
Conversation
| - java: '11' | ||
| version: '22.3.2' | ||
| components: 'native-image' | ||
| name: 'Java 11 | GraalVM 22.3.2' | ||
| - java: '17' | ||
| version: '22.3.2' | ||
| components: 'native-image' | ||
| name: 'Java 17 | GraalVM 22.3.2' | ||
| - java: '17.0.8' | ||
| distribution: 'graalvm' | ||
| name: 'GraalVM for Java 17 | 17.0.8' | ||
| - java: '20.0.2' | ||
| distribution: 'graalvm' | ||
| name: 'GraalVM for Java 20 | 20.0.2' |
There was a problem hiding this comment.
@mpeddada1 @burkedavison Is this the right set of versions?
There was a problem hiding this comment.
Just for reference, first two are 22.3.2 version with Java 11 and 17 similar to what we have internally for client libraries.
and the last two are for the latest GraalVM release (23.x) for JDK 17 and JDK 20. No support for JDK 11.
There was a problem hiding this comment.
We aren't yet supporting the last two, but if the tests are passing it doesn't hurt.
There was a problem hiding this comment.
update: removed the latest GraalVM release (23.x) for JDK 17 and JDK 20 in 62b1506.
| [ | ||
| { | ||
| "name":"com.google.rpc.BadRequest", | ||
| "methods":[{"name":"getFieldViolations","parameterTypes":["int"] }, {"name":"getFieldViolationsCount","parameterTypes":[] }, {"name":"getFieldViolationsList","parameterTypes":[] }] | ||
| }, |
There was a problem hiding this comment.
@jainsahab Do we happen to have a stacktrace of the error message we run into if we don't include these configurations? Mostly curious what class or dependency needs it. If it is come from a client library or it's dependency (like gax) then we may be adding the configuration too late in the release cycle.
There was a problem hiding this comment.
There was a problem hiding this comment.
One thing i would like to point out @mpeddada1 that this is just happening for the latest GraalVM releases (23.x) for JDK 17 and JDK 20
There was a problem hiding this comment.
it's been deleted now as part of 62b1506
pom.xml
Outdated
| <buildArg>--no-fallback</buildArg> | ||
| <buildArg>--no-server</buildArg> | ||
| <!-- Until https://github.com/googleapis/sdk-platform-java/pull/1892 is merged --> | ||
| <buildArg>-H:+RunReachabilityHandlersConcurrently</buildArg> |
There was a problem hiding this comment.
The argument in native-image.properties should automatically get picked up by the plugin so we may not need to add it in here as well.
There was a problem hiding this comment.
i tried removing this option from pom.xml on GraalVM for java 17, and this is the error i am getting consistently.
But when i explicitly pass this option in pom.xml, I am able to build it successfully, we can also see that this argument is being passed to native-image command line options.
There was a problem hiding this comment.
Until we can turn off this flag in early September, the configuration here might conflict with our other client libraries.
We shouldn't be spending too much time trying to get support for currently-unsupported versions of GraalVM.
There was a problem hiding this comment.
sure, removed the configuration for GraalVM for java 17 and 20.
|
Kudos, SonarCloud Quality Gate passed!
|
cloud-spanner-r2dbc/src/test/resources/META-INF/native-image/native-image.properties
Show resolved
Hide resolved
No description provided.