Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heads up: when clauses may be broken with the next VS Code release #748

Closed
ulugbekna opened this issue Mar 6, 2023 · 3 comments
Closed

Comments

@ulugbekna
Copy link

Hi 👋

VS Code team engineer here 🙂

We're reworking how we parse when clause contexts and noticed that we may break some of the when clauses used in your extension. You can read more in this issue, which describes upcoming changes: new features, breakages, and migration advice (latest VS Code Insiders now has a linter for when clauses and runs the new parser as default). You can also leave us feedback there.

Thanks for a great extension, it's very popular!

Best,
Ulugbek

@SKrupa
Copy link
Contributor

SKrupa commented Mar 7, 2023

Hi Ulugbek, thanks for the heads up! From the linter, looks like we should be unaffected but we're going through and double checking for our next release.

@ulugbekna
Copy link
Author

Keep in mind that g and y flags in regexes are accepted but ignored.

@glouischandra
Copy link
Collaborator

Hello @ulugbekna we've audited our extension and the changes doesn't affect our extension. Closing this thread and thank you for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants