Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: consolidate repos #966

Merged
merged 1,071 commits into from
Dec 9, 2023
Merged

feat: consolidate repos #966

merged 1,071 commits into from
Dec 9, 2023

Conversation

JoeWang1127
Copy link
Contributor

No description provided.

chanseokoh and others added 30 commits June 14, 2019 17:44
@chanseokoh
Remove Kokoro sign and publish scripts (#391)
b16a5ad 
* Delete release_publish.sh

* Delete release_sign.sh
@loosebazooka
update version in readme (#346)
4d88fc4
@loosebazooka
Add gcloudMode config option for beta deploy (#394)
b62076a
@loosebazooka
Add gcloudMode option to deploy (#356)
63c02c7 
* Add appengine.deploy.gcloudMode config for beta deploy
@loosebazooka
Release v2.1.0 (#357)
7c95635 
* [Gradle Release Plugin] - pre tag commit:  'v2.1.0'.

* [Gradle Release Plugin] - new version commit:  'v2.1.1-SNAPSHOT'.
@loosebazooka
2.1.0 (#395)
ab67a42 
* preparing release 2.1.0

* 2.1.1-SNAPSHOT
@loosebazooka
switch from oraclejdk8 to openjdk8 on travis (#397)
3062107 
* switch from oraclejdk8 to openjdk8 on travis
@loosebazooka
Update readme version to 2.1.0 (#359)
7442e01
@loosebazooka
Update readme version to 2.1.0 (#398)
d3b24a0
@loosebazooka
Add extraFilesDirectories to USER_GUIDE. (#400)
adf029c 
- also minor cleanup
@loosebazooka
Update USER_GUIDE.md (#360)
0b0b781
@loosebazooka
Rearrage docs, add faq for thin jars (#401)
5d0fc8d 
* Rearrage docs, add faq for thin jars
@loosebazooka
Add more of the letter S (#403)
0722c6c
@loosebazooka
more userguide cleanup (#404)
a2466a1 
* remove thin jar full config, just describe how to use extraFilesDirectories
@loosebazooka
Reorg readme (#361)
e251d05
@elharo
update dependencies (#802)
b17c197 
* update dependencies
* specify trusty
* use trusty for JDK 8
@elharo
New library versions (#803)
ee337a4 
* add phishingprotection API
* update library versions
@elharo
GA --> Stable (#805)
80f08ba 
* GA --> Stable

* fix test
@loosebazooka
Support for java11 standard projects "Class-Path" (#804)
d14766d 
* Support for java11 standard projects "Class-Path" copying in the staging directory
@elharo
update mockito (#808)
fe692b3 
* update to mockito 3
@loosebazooka
0.8.0 (#811)
23eef06 
* preparing release 0.8.0

* 0.8.1-SNAPSHOT
@loosebazooka
Create parent if it doesn't exists when copying files (#812)
c644db6 
* Create parent if it doesn't exists when copying files
@loosebazooka
0.8.1 (#813)
cae1256 
* preparing release 0.8.1

* 0.8.2-SNAPSHOT
@elharo @loosebazooka
fix minor javadoc warning (#806)
86621a8
@loosebazooka
Upgrade plugins-core to 0.8.1 (#405)
a9f07f9 
Adds extended support for thin jar deployments, automatically copying
jars referenced in Class-Path in the source artifact to the staging
directory.
@loosebazooka
Upgrade plugins-core to 0.8.1 (#364)
b7e4c95 
Adds extended support for thin jar deployments, automatically copying
jars referenced in Class-Path in the source artifact to the staging
directory.
@loosebazooka
2.2.0 (#406)
9663baf 
* preparing release 2.2.0

* 2.2.1-SNAPSHOT
@loosebazooka
Release v2.2.0 (#365)
67d9672 
* [Gradle Release Plugin] - pre tag commit:  'v2.2.0'.

* [Gradle Release Plugin] - new version commit:  'v2.2.1-SNAPSHOT'.
@loosebazooka
Update README.md and CHANGELOG.md (#366)
ade86fa 
* Update README.md

* Update CHANGELOG.md
@loosebazooka
Update README.md and CHANGELOG.md (#407)
9eb0ca1 
* Update README.md

* Update CHANGELOG.md
@JoeWang1127
Copy link
Contributor Author

JoeWang1127 commented Dec 7, 2023 •
edited
Loading

Kokoro-ubentu build failed:

testDeployStandard: INFO: submitting command: /root/.cache/google-cloud-tools-java/managed-cloud-sdk/LATEST/google-cloud-sdk/bin/gcloud app deploy /tmpfs/src/github/appengine-plugins/app-maven-plugin/target/test-classes/projects/standard-project/target/appengine-staging/app.yaml /tmpfs/src/github/appengine-plugins/app-maven-plugin/target/test-classes/projects/standard-project/target/appengine-staging/WEB-INF/appengine-generated/cron.yaml /tmpfs/src/github/appengine-plugins/app-maven-plugin/target/test-classes/projects/standard-project/target/appengine-staging/WEB-INF/appengine-generated/dispatch.yaml /tmpfs/src/github/appengine-plugins/app-maven-plugin/target/test-classes/projects/standard-project/target/appengine-staging/WEB-INF/appengine-generated/dos.yaml /tmpfs/src/github/appengine-plugins/app-maven-plugin/target/test-classes/projects/standard-project/target/appengine-staging/WEB-INF/appengine-generated/index.yaml /tmpfs/src/github/appengine-plugins/app-maven-plugin/target/test-classes/projects/standard-project/target/appengine-staging/WEB-INF/appengine-generated/queue.yaml --version GCLOUD_VERSION --project travis-app-maven-plugin
Exit code: 1
testDeployStandard: [INFO] GCLOUD: ERROR: (gcloud.app.deploy) argument --version/-v: Bad value [GCLOUD_VERSION]: May only contain lowercase letters, digits, and hyphens. Must begin and end with a letter or digit. Must not exceed 63 characters.
testDeployStandard: [INFO] GCLOUD: Usage: gcloud app deploy [DEPLOYABLES ...] [optional flags]
testDeployStandard: [INFO] GCLOUD:   optional flags may be  --appyaml | --bucket | --cache | --help |
testDeployStandard: [INFO] GCLOUD:                          --ignore-file | --image-url | --promote |
testDeployStandard: [INFO] GCLOUD:                          --service-account | --stop-previous-version | --version
testDeployStandard: [INFO] GCLOUD: 
testDeployStandard: [INFO] GCLOUD: For detailed information on this command and its flags, run:
testDeployStandard: [INFO] GCLOUD:   gcloud app deploy --help

Full log: link
I deleted GCLOUD_VERSION in commit.

The error became:

testDeployStandard: INFO: submitting command: /root/.cache/google-cloud-tools-java/managed-cloud-sdk/LATEST/google-cloud-sdk/bin/gcloud app deploy --version 1 --project travis-app-maven-plugin
testDeployStandard: [INFO] GCLOUD: ERROR: (gcloud.app.deploy) Permissions error fetching application [apps/travis-app-maven-plugin]. Please make sure that you have permission to view applications on the project and that [email protected] has the App Engine Deployer (roles/appengine.deployer) role.

Full log: link

@suztomo
Copy link
Contributor

suztomo commented Dec 7, 2023

I think you're in the right direction. The environment setup in app-maven-plugin's Kokoro job needs to come here.

@JoeWang1127
Copy link
Contributor Author

Unit test run with Java 17 and 21 failed because Gradle 6.9 is not compatible with Java 17/21.

@suztomo
Copy link
Contributor

suztomo commented Dec 8, 2023

Focus on appengine-plugins-core and app-maven-plugin in this pull request.

Gradle 6.9 is not compatible with Java 17/21.

I believe Gradle is not used in the two. In that case skip app-gradle-plugin there.

@JoeWang1127
Copy link
Contributor Author

I believe Gradle is not used in the two. In that case skip app-gradle-plugin there.

I skipped Gradle project when Java is 17 and 21.

Now the unit tests are successfully.

@google-cla google-cla bot added cla: yes and removed cla: no labels Dec 9, 2023
@JoeWang1127 JoeWang1127 merged commit a6606a0 into main Dec 9, 2023
5 checks passed
@JoeWang1127 JoeWang1127 deleted the feat/consolidate-repos branch December 9, 2023 00:25
@release-please release-please bot mentioned this pull request Dec 13, 2023
Closed
@release-please release-please bot mentioned this pull request Jan 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.