Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: wait none waits for navigation to be committed #3086

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

sadym-chromium
Copy link
Collaborator

@sadym-chromium sadym-chromium commented Feb 6, 2025

Refactor NavigationTracker will be in a follow-up.

Tested with web-platform-tests/wpt#50527.

@sadym-chromium sadym-chromium added the update-expectations Update WPT expectations label Feb 6, 2025
browser-automation-bot added a commit to browser-automation-bot/chromium-bidi that referenced this pull request Feb 6, 2025
sadym-chromium pushed a commit that referenced this pull request Feb 6, 2025
sadym-chromium pushed a commit that referenced this pull request Feb 6, 2025
@sadym-chromium sadym-chromium force-pushed the sadym/wait-committed branch 3 times, most recently from 80d6c37 to 508e2c1 Compare February 6, 2025 14:07
@sadym-chromium sadym-chromium requested a review from OrKoN February 6, 2025 14:09
@sadym-chromium sadym-chromium reopened this Feb 6, 2025
sadym-chromium pushed a commit that referenced this pull request Feb 6, 2025
browser-automation-bot added a commit to browser-automation-bot/chromium-bidi that referenced this pull request Feb 6, 2025
sadym-chromium pushed a commit that referenced this pull request Feb 6, 2025
browser-automation-bot added a commit to browser-automation-bot/chromium-bidi that referenced this pull request Feb 6, 2025
browser-automation-bot added a commit to browser-automation-bot/chromium-bidi that referenced this pull request Feb 6, 2025
sadym-chromium added a commit that referenced this pull request Feb 7, 2025
@sadym-chromium sadym-chromium changed the title [WIP] feat: wait none waits for navigation to be committed. feat: wait none waits for navigation to be committed. Feb 7, 2025
@sadym-chromium sadym-chromium changed the title feat: wait none waits for navigation to be committed. [WIP] feat: wait none waits for navigation to be committed. Feb 7, 2025
@sadym-chromium sadym-chromium changed the title [WIP] feat: wait none waits for navigation to be committed. feat: wait none waits for navigation to be committed Feb 7, 2025
@sadym-chromium sadym-chromium marked this pull request as ready for review February 7, 2025 15:23
browser-automation-bot added a commit to browser-automation-bot/chromium-bidi that referenced this pull request Feb 7, 2025
sadym-chromium pushed a commit that referenced this pull request Feb 10, 2025
browser-automation-bot added a commit to browser-automation-bot/chromium-bidi that referenced this pull request Feb 10, 2025
sadym-chromium added a commit that referenced this pull request Feb 10, 2025
sadym-chromium added a commit that referenced this pull request Feb 10, 2025
command finishes after the navigation committed
@sadym-chromium sadym-chromium merged commit b8f30b1 into main Feb 10, 2025
50 checks passed
@sadym-chromium sadym-chromium deleted the sadym/wait-committed branch February 10, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge update-expectations Update WPT expectations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants