From 062d8266f45e324360d917a711f4b8250629e148 Mon Sep 17 00:00:00 2001 From: Ward Peeters Date: Sat, 14 Oct 2017 16:05:50 +0200 Subject: [PATCH 1/7] Add bootup-time audit --- lighthouse-core/audits/bootup-time.js | 97 +++++++++++++++++++++++++++ lighthouse-core/config/default.js | 2 + 2 files changed, 99 insertions(+) create mode 100644 lighthouse-core/audits/bootup-time.js diff --git a/lighthouse-core/audits/bootup-time.js b/lighthouse-core/audits/bootup-time.js new file mode 100644 index 000000000000..5e921d4e3892 --- /dev/null +++ b/lighthouse-core/audits/bootup-time.js @@ -0,0 +1,97 @@ +/** + * @license Copyright 2017 Google Inc. All Rights Reserved. + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + */ +'use strict'; + +const Audit = require('./audit'); +const DevtoolsTimelineModel = require('../lib/traces/devtools-timeline-model'); +const Util = require('../report/v2/renderer/util.js'); + +class BootupTime extends Audit { + /** + * @return {!AuditMeta} + */ + static get meta() { + return { + category: 'Performance', + name: 'bootup-time', + description: 'JavaScript boot-up time is high (> 4s)', + failureDescription: 'JavaScript boot-up time is too high.', + helpText: 'Consider reducing the time spent parsing, compiling and executing JS. ' + + 'You may find delivering smaller JS payloads helps with this.', + requiredArtifacts: ['traces'], + }; + } + + /** + * @param {!Array=} trace + * @return {!Map} + */ + static getExecutionTimingsByURL(trace) { + const timelineModel = new DevtoolsTimelineModel(trace); + const bottomUpByName = timelineModel.bottomUpGroupBy('URL'); + const result = new Map(); + bottomUpByName.children.forEach((value, url) => { + // when url is "", we skip it + if (!url) { + return; + } + + const evaluateTime = value.children.get('EvaluateScript:@' + url) || {}; + const compileTime = value.children.get('v8.compile:@' + url) || {}; + + if (evaluateTime.selfTime || compileTime.selfTime) { + result.set(url, { + evaluate: Number((evaluateTime.selfTime || 0).toFixed(1)), + compile: Number((compileTime.selfTime || 0).toFixed(1)), + }); + } + }); + + return result; + } + + /** + * @param {!Artifacts} artifacts + * @return {!AuditResult} + */ + static audit(artifacts) { + const trace = artifacts.traces[BootupTime.DEFAULT_PASS]; + const bootupTimings = BootupTime.getExecutionTimingsByURL(trace); + + let totalBootupTime = 0; + + const extendedInfo = {}; + const results = Array.from(bootupTimings).map(([url, durations]) => { + totalBootupTime += durations.evaluate + durations.compile; + extendedInfo[url] = durations; + + return { + url: url, + evaluate: Util.formatMilliseconds(durations.evaluate, 1), + compile: Util.formatMilliseconds(durations.compile, 1), + }; + }); + + const headings = [ + {key: 'url', itemType: 'url', text: 'URL'}, + {key: 'evaluate', itemType: 'text', text: 'Time To Evaluate'}, + {key: 'compile', itemType: 'text', text: 'Time To Compile'}, + ]; + const tableDetails = BootupTime.makeTableDetails(headings, results); + + return { + score: totalBootupTime < 4000, + rawValue: totalBootupTime, + displayValue: Util.formatMilliseconds(totalBootupTime), + details: tableDetails, + extendedInfo: { + value: extendedInfo, + }, + }; + } +} + +module.exports = BootupTime; diff --git a/lighthouse-core/config/default.js b/lighthouse-core/config/default.js index 5a6e994d0334..2b9aef40183e 100644 --- a/lighthouse-core/config/default.js +++ b/lighthouse-core/config/default.js @@ -86,6 +86,7 @@ module.exports = { 'content-width', 'image-aspect-ratio', 'deprecations', + 'bootup-time', 'manual/pwa-cross-browser', 'manual/pwa-page-transitions', 'manual/pwa-each-page-has-url', @@ -242,6 +243,7 @@ module.exports = { {id: 'dom-size', weight: 0, group: 'perf-info'}, {id: 'critical-request-chains', weight: 0, group: 'perf-info'}, {id: 'user-timings', weight: 0, group: 'perf-info'}, + {id: 'bootup-time', weight: 0, group: 'perf-info'}, {id: 'screenshot-thumbnails', weight: 0}, ], }, From 965b96057384cd74e8d7e855e6f76c5d0201a7eb Mon Sep 17 00:00:00 2001 From: Ward Peeters Date: Sat, 14 Oct 2017 16:44:25 +0200 Subject: [PATCH 2/7] Add unit tests for bootup-time --- .../test/audits/bootup-time-test.js | 60 +++++++++++++++++++ 1 file changed, 60 insertions(+) create mode 100644 lighthouse-core/test/audits/bootup-time-test.js diff --git a/lighthouse-core/test/audits/bootup-time-test.js b/lighthouse-core/test/audits/bootup-time-test.js new file mode 100644 index 000000000000..eac179b5c744 --- /dev/null +++ b/lighthouse-core/test/audits/bootup-time-test.js @@ -0,0 +1,60 @@ +/** + * @license Copyright 2017 Google Inc. All Rights Reserved. + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + */ +'use strict'; + +/* eslint-env mocha */ +const BootupTime = require('../../audits/bootup-time.js'); +const fs = require('fs'); +const assert = require('assert'); + +// sadly require(file) is not working correctly. +// traceParser parser returns preact trace data the same as JSON.parse +// fails when require is used +const acceptableTrace = JSON.parse( + fs.readFileSync(__dirname + '/../fixtures/traces/progressive-app-m60.json') +); +const errorTrace = JSON.parse( + fs.readFileSync(__dirname + '/../fixtures/traces/airhorner_no_fcp.json') +); + +describe('Performance: bootup-time audit', () => { + it('should compute the correct BootupTime values', (done) => { + const artifacts = { + traces: { + [BootupTime.DEFAULT_PASS]: acceptableTrace, + }, + }; + + const output = BootupTime.audit(artifacts); + assert.equal(output.details.items.length, 7); + assert.equal(output.score, true); + assert.equal(Math.round(output.rawValue), 155); + + const valueOf = name => output.extendedInfo.value[name]; + assert.deepEqual(valueOf('https://www.google-analytics.com/analytics.js'), {evaluate: 40.1, compile: 9.6}); + assert.deepEqual(valueOf('https://pwa.rocks/script.js'), {evaluate: 31.8, compile: 1.3}); + assert.deepEqual(valueOf('https://www.googletagmanager.com/gtm.js?id=GTM-Q5SW'), {evaluate: 25, compile: 5.5}); + assert.deepEqual(valueOf('https://www.google-analytics.com/plugins/ua/linkid.js'), {evaluate: 25.2, compile: 1.2}); + assert.deepEqual(valueOf('https://pwa.rocks/'), {evaluate: 6.1, compile: 1.2}); + assert.deepEqual(valueOf('https://www.google-analytics.com/cx/api.js?experiment=jdCfRmudTmy-0USnJ8xPbw'), {evaluate: 1.2, compile: 3}); + assert.deepEqual(valueOf('https://www.google-analytics.com/cx/api.js?experiment=qvpc5qIfRC2EMnbn6bbN5A'), {evaluate: 1, compile: 2.5}); + + done(); + }); + + it('should get no data when no events are present', () => { + const artifacts = { + traces: { + [BootupTime.DEFAULT_PASS]: errorTrace, + }, + }; + + const output = BootupTime.audit(artifacts); + assert.equal(output.details.items.length, 0); + assert.equal(output.score, true); + assert.equal(Math.round(output.rawValue), 0); + }); +}); From e619d86a18e96851631900f217eead0821da424d Mon Sep 17 00:00:00 2001 From: Ward Peeters Date: Tue, 17 Oct 2017 16:26:19 +0200 Subject: [PATCH 3/7] Review fixes --- lighthouse-core/audits/bootup-time.js | 38 +++++++++++++-------------- lighthouse-core/config/test-config.js | 15 +++++++++++ 2 files changed, 34 insertions(+), 19 deletions(-) create mode 100644 lighthouse-core/config/test-config.js diff --git a/lighthouse-core/audits/bootup-time.js b/lighthouse-core/audits/bootup-time.js index 5e921d4e3892..ceb515297415 100644 --- a/lighthouse-core/audits/bootup-time.js +++ b/lighthouse-core/audits/bootup-time.js @@ -7,6 +7,7 @@ const Audit = require('./audit'); const DevtoolsTimelineModel = require('../lib/traces/devtools-timeline-model'); +const WebInspector = require('../lib/web-inspector'); const Util = require('../report/v2/renderer/util.js'); class BootupTime extends Audit { @@ -33,21 +34,20 @@ class BootupTime extends Audit { const timelineModel = new DevtoolsTimelineModel(trace); const bottomUpByName = timelineModel.bottomUpGroupBy('URL'); const result = new Map(); - bottomUpByName.children.forEach((value, url) => { + + bottomUpByName.children.forEach((perUrlNode, url) => { // when url is "", we skip it if (!url) { return; } - const evaluateTime = value.children.get('EvaluateScript:@' + url) || {}; - const compileTime = value.children.get('v8.compile:@' + url) || {}; - - if (evaluateTime.selfTime || compileTime.selfTime) { - result.set(url, { - evaluate: Number((evaluateTime.selfTime || 0).toFixed(1)), - compile: Number((compileTime.selfTime || 0).toFixed(1)), - }); - } + const tasks = {}; + perUrlNode.children.forEach((perTaskPerUrlNode) => { + const taskGroup = WebInspector.TimelineUIUtils.eventStyle(perTaskPerUrlNode.event); + tasks[taskGroup.title] = tasks[taskGroup.title] || 0; + tasks[taskGroup.title] += Number((perTaskPerUrlNode.selfTime || 0).toFixed(1)); + }); + result.set(url, tasks); }); return result; @@ -64,22 +64,22 @@ class BootupTime extends Audit { let totalBootupTime = 0; const extendedInfo = {}; + const headings = [ + {key: 'url', itemType: 'url', text: 'URL'}, + ]; const results = Array.from(bootupTimings).map(([url, durations]) => { totalBootupTime += durations.evaluate + durations.compile; extendedInfo[url] = durations; - return { + Object.keys(durations).forEach(key => { + headings.push({ key, itemType: 'text', text: key }); + }); + + return Object.assign({}, { url: url, - evaluate: Util.formatMilliseconds(durations.evaluate, 1), - compile: Util.formatMilliseconds(durations.compile, 1), - }; + }, durations); }); - const headings = [ - {key: 'url', itemType: 'url', text: 'URL'}, - {key: 'evaluate', itemType: 'text', text: 'Time To Evaluate'}, - {key: 'compile', itemType: 'text', text: 'Time To Compile'}, - ]; const tableDetails = BootupTime.makeTableDetails(headings, results); return { diff --git a/lighthouse-core/config/test-config.js b/lighthouse-core/config/test-config.js new file mode 100644 index 000000000000..fa724e453111 --- /dev/null +++ b/lighthouse-core/config/test-config.js @@ -0,0 +1,15 @@ +/** + * @license Copyright 2017 Google Inc. All Rights Reserved. + * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 + * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. + */ +'use strict'; + +module.exports = { + extends: 'lighthouse:default', + settings: { + onlyAudits: [ + 'bootup-time', + ] + }, +}; From cf47eaf593f5ddae6057d380fff4883d040897bd Mon Sep 17 00:00:00 2001 From: Ward Peeters Date: Sat, 21 Oct 2017 14:46:24 +0200 Subject: [PATCH 4/7] Updated unit tests --- lighthouse-core/audits/bootup-time.js | 124 ++++++++++++++++-- .../test/audits/bootup-time-test.js | 19 +-- 2 files changed, 125 insertions(+), 18 deletions(-) diff --git a/lighthouse-core/audits/bootup-time.js b/lighthouse-core/audits/bootup-time.js index ceb515297415..c311fba445fd 100644 --- a/lighthouse-core/audits/bootup-time.js +++ b/lighthouse-core/audits/bootup-time.js @@ -10,6 +10,88 @@ const DevtoolsTimelineModel = require('../lib/traces/devtools-timeline-model'); const WebInspector = require('../lib/web-inspector'); const Util = require('../report/v2/renderer/util.js'); +const group = { + loading: 'Network request loading', + parseHTML: 'Parsing DOM', + styleLayout: 'Style & Layout', + compositing: 'Compositing', + painting: 'Paint', + gpu: 'GPU', + scripting: 'Script Evaluation', + scriptParseCompile: 'Script Parsing & Compile', + scriptGC: 'Garbage collection', + other: 'Other', + images: 'Images', +}; +const taskToGroup = { + 'Animation': group.painting, + 'Async Task': group.other, + 'Frame Start': group.painting, + 'Frame Start (main thread)': group.painting, + 'Cancel Animation Frame': group.scripting, + 'Cancel Idle Callback': group.scripting, + 'Compile Script': group.scriptParseCompile, + 'Composite Layers': group.compositing, + 'Console Time': group.scripting, + 'Image Decode': group.images, + 'Draw Frame': group.painting, + 'Embedder Callback': group.scripting, + 'Evaluate Script': group.scripting, + 'Event': group.scripting, + 'Animation Frame Fired': group.scripting, + 'Fire Idle Callback': group.scripting, + 'Function Call': group.scripting, + 'DOM GC': group.scriptGC, + 'GC Event': group.scriptGC, + 'GPU': group.gpu, + 'Hit Test': group.compositing, + 'Invalidate Layout': group.styleLayout, + 'JS Frame': group.scripting, + 'Input Latency': group.scripting, + 'Layout': group.styleLayout, + 'Major GC': group.scriptGC, + 'DOMContentLoaded event': group.scripting, + 'First paint': group.painting, + 'FMP': group.painting, + 'FMP candidate': group.painting, + 'Load event': group.scripting, + 'Minor GC': group.scriptGC, + 'Paint': group.painting, + 'Paint Image': group.images, + 'Paint Setup': group.painting, + 'Parse Stylesheet': group.parseHTML, + 'Parse HTML': group.parseHTML, + 'Parse Script': group.scriptParseCompile, + 'Other': group.other, + 'Rasterize Paint': group.painting, + 'Recalculate Style': group.styleLayout, + 'Request Animation Frame': group.scripting, + 'Request Idle Callback': group.scripting, + 'Request Main Thread Frame': group.painting, + 'Image Resize': group.images, + 'Finish Loading': group.loading, + 'Receive Data': group.loading, + 'Receive Response': group.loading, + 'Send Request': group.loading, + 'Run Microtasks': group.scripting, + 'Schedule Style Recalculation': group.styleLayout, + 'Scroll': group.compositing, + 'Task': group.other, + 'Timer Fired': group.scripting, + 'Install Timer': group.scripting, + 'Remove Timer': group.scripting, + 'Timestamp': group.scripting, + 'Update Layer': group.compositing, + 'Update Layer Tree': group.compositing, + 'User Timing': group.scripting, + 'Create WebSocket': group.scripting, + 'Destroy WebSocket': group.scripting, + 'Receive WebSocket Handshake': group.scripting, + 'Send WebSocket Handshake': group.scripting, + 'XHR Load': group.scripting, + 'XHR Ready State Change': group.scripting, +}; + class BootupTime extends Audit { /** * @return {!AuditMeta} @@ -36,8 +118,8 @@ class BootupTime extends Audit { const result = new Map(); bottomUpByName.children.forEach((perUrlNode, url) => { - // when url is "", we skip it - if (!url) { + // when url is "" or about:blank, we skip it + if (!url || url === 'about:blank') { return; } @@ -62,22 +144,46 @@ class BootupTime extends Audit { const bootupTimings = BootupTime.getExecutionTimingsByURL(trace); let totalBootupTime = 0; - const extendedInfo = {}; const headings = [ {key: 'url', itemType: 'url', text: 'URL'}, ]; - const results = Array.from(bootupTimings).map(([url, durations]) => { - totalBootupTime += durations.evaluate + durations.compile; + + // Group tasks per url + const groupsPerUrl = Array.from(bootupTimings).map(([url, durations]) => { extendedInfo[url] = durations; - Object.keys(durations).forEach(key => { - headings.push({ key, itemType: 'text', text: key }); + const groups = []; + Object.keys(durations).forEach(task => { + totalBootupTime += durations[task]; + const group = taskToGroup[task]; + + groups[group] = groups[group] || 0; + groups[group] += durations[task]; + + if (!headings.find(heading => heading.key === group)) { + headings.push( + {key: group, itemType: 'text', text: group} + ); + } }); - return Object.assign({}, { + return { url: url, - }, durations); + groups, + }; + }); + + // map data in correct format to create a table + const results = groupsPerUrl.map(({url, groups}) => { + const res = {}; + headings.forEach(heading => { + res[heading.key] = Util.formatMilliseconds(groups[heading.key] || 0, 1); + }); + + res.url = url; + + return res; }); const tableDetails = BootupTime.makeTableDetails(headings, results); diff --git a/lighthouse-core/test/audits/bootup-time-test.js b/lighthouse-core/test/audits/bootup-time-test.js index eac179b5c744..b16cd70294a1 100644 --- a/lighthouse-core/test/audits/bootup-time-test.js +++ b/lighthouse-core/test/audits/bootup-time-test.js @@ -29,18 +29,19 @@ describe('Performance: bootup-time audit', () => { }; const output = BootupTime.audit(artifacts); - assert.equal(output.details.items.length, 7); + assert.equal(output.details.items.length, 8); assert.equal(output.score, true); - assert.equal(Math.round(output.rawValue), 155); + assert.equal(Math.round(output.rawValue), 176); const valueOf = name => output.extendedInfo.value[name]; - assert.deepEqual(valueOf('https://www.google-analytics.com/analytics.js'), {evaluate: 40.1, compile: 9.6}); - assert.deepEqual(valueOf('https://pwa.rocks/script.js'), {evaluate: 31.8, compile: 1.3}); - assert.deepEqual(valueOf('https://www.googletagmanager.com/gtm.js?id=GTM-Q5SW'), {evaluate: 25, compile: 5.5}); - assert.deepEqual(valueOf('https://www.google-analytics.com/plugins/ua/linkid.js'), {evaluate: 25.2, compile: 1.2}); - assert.deepEqual(valueOf('https://pwa.rocks/'), {evaluate: 6.1, compile: 1.2}); - assert.deepEqual(valueOf('https://www.google-analytics.com/cx/api.js?experiment=jdCfRmudTmy-0USnJ8xPbw'), {evaluate: 1.2, compile: 3}); - assert.deepEqual(valueOf('https://www.google-analytics.com/cx/api.js?experiment=qvpc5qIfRC2EMnbn6bbN5A'), {evaluate: 1, compile: 2.5}); + assert.deepEqual(valueOf('https://www.google-analytics.com/analytics.js'), {'Evaluate Script': 40.1, 'Compile Script': 9.6, 'Recalculate Style': 0.2}); + assert.deepEqual(valueOf('https://pwa.rocks/script.js'), {'Evaluate Script': 31.8,'Layout': 5.5, 'Compile Script': 1.3}); + assert.deepEqual(valueOf('https://www.googletagmanager.com/gtm.js?id=GTM-Q5SW'), {'Evaluate Script': 25, 'Compile Script': 5.5, 'Recalculate Style': 1.2}); + assert.deepEqual(valueOf('https://www.google-analytics.com/plugins/ua/linkid.js'), {'Evaluate Script': 25.2, 'Compile Script': 1.2}); + assert.deepEqual(valueOf('https://www.google-analytics.com/cx/api.js?experiment=jdCfRmudTmy-0USnJ8xPbw'), {'Compile Script': 3, 'Evaluate Script': 1.2}); + assert.deepEqual(valueOf('https://www.google-analytics.com/cx/api.js?experiment=qvpc5qIfRC2EMnbn6bbN5A'), {'Compile Script': 2.5, 'Evaluate Script': 1}); + assert.deepEqual(valueOf('https://pwa.rocks/'), {'Parse HTML': 14.2, 'Evaluate Script': 6.1, 'Compile Script': 1.2}); + assert.deepEqual(valueOf('https://pwa.rocks/0ff789bf.js'), {'Parse HTML': 0}); done(); }); From a824a664fb6f4632e38f6281b95ead82d283f85d Mon Sep 17 00:00:00 2001 From: Ward Peeters Date: Sat, 21 Oct 2017 14:57:48 +0200 Subject: [PATCH 5/7] Remove test-config --- lighthouse-core/config/test-config.js | 15 --------------- 1 file changed, 15 deletions(-) delete mode 100644 lighthouse-core/config/test-config.js diff --git a/lighthouse-core/config/test-config.js b/lighthouse-core/config/test-config.js deleted file mode 100644 index fa724e453111..000000000000 --- a/lighthouse-core/config/test-config.js +++ /dev/null @@ -1,15 +0,0 @@ -/** - * @license Copyright 2017 Google Inc. All Rights Reserved. - * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with the License. You may obtain a copy of the License at http://www.apache.org/licenses/LICENSE-2.0 - * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License. - */ -'use strict'; - -module.exports = { - extends: 'lighthouse:default', - settings: { - onlyAudits: [ - 'bootup-time', - ] - }, -}; From 8ec5fb3cc9c1f82b67d7195980ce385aef92a84f Mon Sep 17 00:00:00 2001 From: Ward Peeters Date: Sat, 21 Oct 2017 15:30:57 +0200 Subject: [PATCH 6/7] Fix linting --- lighthouse-core/test/audits/bootup-time-test.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lighthouse-core/test/audits/bootup-time-test.js b/lighthouse-core/test/audits/bootup-time-test.js index b16cd70294a1..27989c9cafbe 100644 --- a/lighthouse-core/test/audits/bootup-time-test.js +++ b/lighthouse-core/test/audits/bootup-time-test.js @@ -35,7 +35,7 @@ describe('Performance: bootup-time audit', () => { const valueOf = name => output.extendedInfo.value[name]; assert.deepEqual(valueOf('https://www.google-analytics.com/analytics.js'), {'Evaluate Script': 40.1, 'Compile Script': 9.6, 'Recalculate Style': 0.2}); - assert.deepEqual(valueOf('https://pwa.rocks/script.js'), {'Evaluate Script': 31.8,'Layout': 5.5, 'Compile Script': 1.3}); + assert.deepEqual(valueOf('https://pwa.rocks/script.js'), {'Evaluate Script': 31.8, 'Layout': 5.5, 'Compile Script': 1.3}); assert.deepEqual(valueOf('https://www.googletagmanager.com/gtm.js?id=GTM-Q5SW'), {'Evaluate Script': 25, 'Compile Script': 5.5, 'Recalculate Style': 1.2}); assert.deepEqual(valueOf('https://www.google-analytics.com/plugins/ua/linkid.js'), {'Evaluate Script': 25.2, 'Compile Script': 1.2}); assert.deepEqual(valueOf('https://www.google-analytics.com/cx/api.js?experiment=jdCfRmudTmy-0USnJ8xPbw'), {'Compile Script': 3, 'Evaluate Script': 1.2}); From b30bc1397e539d1362403b8889a76b4aed1a6034 Mon Sep 17 00:00:00 2001 From: Ward Peeters Date: Fri, 3 Nov 2017 16:17:47 +0100 Subject: [PATCH 7/7] Remove . from failuredescription --- lighthouse-core/audits/bootup-time.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lighthouse-core/audits/bootup-time.js b/lighthouse-core/audits/bootup-time.js index c311fba445fd..36fd5777e871 100644 --- a/lighthouse-core/audits/bootup-time.js +++ b/lighthouse-core/audits/bootup-time.js @@ -101,7 +101,7 @@ class BootupTime extends Audit { category: 'Performance', name: 'bootup-time', description: 'JavaScript boot-up time is high (> 4s)', - failureDescription: 'JavaScript boot-up time is too high.', + failureDescription: 'JavaScript boot-up time is too high', helpText: 'Consider reducing the time spent parsing, compiling and executing JS. ' + 'You may find delivering smaller JS payloads helps with this.', requiredArtifacts: ['traces'],