Make Non-Verbal Langs Not Play Speech #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GoobBot
changed the title
angelofallars
suggested changes
Jan 6, 2025
|
Consider opening this PR too on the upstream repository of Goob MRP, Einstein Engines: https://github.com/Simple-Station/Einstein-Engines |
will prolly do that in a bit. gimme a sec |
|
ported this PR to Simple-Station/Einstein-Engines#1448 |
|
and to remind anyone wanting to merge this into MRP: don't do it yet. |
|
actually, this PR has to be closed since its now ported to upstream |
Remuchi
pushed a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Jan 7, 2025
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Makes non-verbal languages no longer emit speech sounds. Ported from [Goob-Station-MRP#29](Goob-Station/Goob-Station-MRP#29) at @angelofallars's request. --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p>  </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - tweak: Languages that don't require speech (I.E. Sign Language) will no longer play speech sounds. --------- Signed-off-by: RadsammyT <[email protected]> Co-authored-by: Skubman <[email protected]> Co-authored-by: flyingkarii <[email protected]> Co-authored-by: sleepyyapril <[email protected]> Co-authored-by: SimpleStation Changelogs <[email protected]>
Spatison
pushed a commit
to Spatison/wwdpublic
that referenced
this pull request
Jan 15, 2025
<!-- This is a semi-strict format, you can add/remove sections as needed but the order/format should be kept the same Remove these comments before submitting --> # Description <!-- Explain this PR in as much detail as applicable Some example prompts to consider: How might this affect the game? The codebase? What might be some alternatives to this? How/Who does this benefit/hurt [the game/codebase]? --> Makes non-verbal languages no longer emit speech sounds. Ported from [Goob-Station-MRP#29](Goob-Station/Goob-Station-MRP#29) at @angelofallars's request. --- <!-- This is default collapsed, readers click to expand it and see all your media The PR media section can get very large at times, so this is a good way to keep it clean The title is written using HTML tags The title must be within the <summary> tags or you won't see it --> <details><summary><h1>Media</h1></summary> <p>  </p> </details> --- # Changelog <!-- You can add an author after the `:cl:` to change the name that appears in the changelog (ex: `:cl: Death`) Leaving it blank will default to your GitHub display name This includes all available types for the changelog --> :cl: - tweak: Languages that don't require speech (I.E. Sign Language) will no longer play speech sounds. --------- Signed-off-by: RadsammyT <[email protected]> Co-authored-by: Skubman <[email protected]> Co-authored-by: flyingkarii <[email protected]> Co-authored-by: sleepyyapril <[email protected]> Co-authored-by: SimpleStation Changelogs <[email protected]> (cherry picked from commit 990a57cc77fd535f39826b125b59054e75dfcfb9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes non-verbal languages no longer emit speech sounds. because muh.. mUh.. MUH REALISM!!1!111111!1
Media
Changelog
🆑