Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify projects count in projectsByUserId and userByAddress #1123

Closed
mohammadranjbarz opened this issue Sep 7, 2023 · 7 comments
Closed

Unify projects count in projectsByUserId and userByAddress #1123

mohammadranjbarz opened this issue Sep 7, 2023 · 7 comments
Assignees
Labels
bug Something isn't working

Comments

@mohammadranjbarz
Copy link
Collaborator

In userByAddress web service we return all projects count but in projectsByUserId we return active and listed projects.
After I talked with @RamRamez , it's better to return active and listed project, unless if user who requests is the owner of that wallet address then we should return all projects count.

@RamRamez is it ok?
@CarlosQ96 can you take this?

userByAddress

projectsByUserId

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 12, 2023

Do you have any Idea when this issue will be ready to test? @mohammadranjbarz @CarlosQ96

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 12, 2023

Related to: Giveth/giveth-dapps-v2#3060 (comment)

@maryjaf maryjaf added the bug Something isn't working label Sep 18, 2023
@maryjaf
Copy link
Collaborator

maryjaf commented Sep 18, 2023

Do you have any Idea when this issue will be ready to test? @mohammadranjbarz @CarlosQ96

Kindly reminder @CarlosQ96

@CarlosQ96
Copy link
Collaborator

I'll work on it between today and tomorrow

@CarlosQ96
Copy link
Collaborator

Finished Pr ill merge tomorrow early so we can test. @maryjaf

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 21, 2023

I tested and by this changes the project count in public profile view for the owner has been affected and it isn't correct
@CarlosQ96 & @mateodaza checked and raised this issue Giveth/giveth-dapps-v2#3203

@CarlosQ96
Copy link
Collaborator

Backend done but need frontend to finalize it. Will leave it here in QA column. @maryjaf
Giveth/giveth-dapps-v2#3203

@maryjaf maryjaf closed this as completed Oct 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants