-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify projects count in projectsByUserId and userByAddress #1123
Comments
Do you have any Idea when this issue will be ready to test? @mohammadranjbarz @CarlosQ96 |
Related to: Giveth/giveth-dapps-v2#3060 (comment) |
Kindly reminder @CarlosQ96 |
I'll work on it between today and tomorrow |
Finished Pr ill merge tomorrow early so we can test. @maryjaf |
I tested and by this changes the project count in public profile view for the owner has been affected and it isn't correct |
Backend done but need frontend to finalize it. Will leave it here in QA column. @maryjaf |
In
userByAddress
web service we return all projects count but inprojectsByUserId
we returnactive
andlisted
projects.After I talked with @RamRamez , it's better to return
active
andlisted
project, unless if user who requests is the owner of that wallet address then we should return all projects count.@RamRamez is it ok?
@CarlosQ96 can you take this?
The text was updated successfully, but these errors were encountered: