Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public view | project tags #2544

Closed
MoeNick opened this issue Apr 23, 2023 · 17 comments
Closed

Public view | project tags #2544

MoeNick opened this issue Apr 23, 2023 · 17 comments
Assignees

Comments

@MoeNick
Copy link
Member

MoeNick commented Apr 23, 2023

Please note:

  1. We can only have up to 5 tags on every project.
  2. If a project has no tags, the place for tags needs to be empty.

Group 618.png

Responsive resource

WIP.

Check the design

Link to Figma

@MoeNick
Copy link
Member Author

MoeNick commented Jul 6, 2023

@maryjaf you can test.

@maryjaf
Copy link
Collaborator

maryjaf commented Jul 8, 2023

image Now I see only verified tag for projects , should the campaign name be shown? @MohammadPCh I added this project to a campaign but i didn't see the tag related to campaign image

@MohammadPCh
Copy link
Collaborator

@alireza-sharifpour could you please take a look?

@alireza-sharifpour
Copy link
Member

We don't have the Backend for this feature yet.

@MoeNick
Copy link
Member Author

MoeNick commented Jul 9, 2023

@mohammadranjbarz is it easy to go or it needs efforts?

@mohammadranjbarz
Copy link
Contributor

@mohammadranjbarz is it easy to go or it needs efforts?

No we need to implement something for that, I created an issue for that

Giveth/impact-graph#1051

@laurenluz
Copy link
Member

Can we just skip the tags for the QF MVP... include only two options: "Verified" and "< QF round name >" ??

@MoeNick
Copy link
Member Author

MoeNick commented Jul 13, 2023

we don't need campaigns, it's ok .

@MoeNick
Copy link
Member Author

MoeNick commented Aug 14, 2023

Ok, after the QF release I think we can put it in backlog again

@MoeNick
Copy link
Member Author

MoeNick commented Sep 7, 2023

I think this is now unblocked for front end ? Did you test the backed @maryjaf ?

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 25, 2023

1-project owner view
Image

2- For a project in a round campaign tag isn't shown
For example there are these two projects in a campaign
https://staging.giveth.io/project/how-many-photos-is-too-many-photos
https://staging.giveth.io/project/a-delicious-help
The campaign tag isn't shown in "a-delicious-help " project page
@alireza-sharifpour @MohammadPCh

@alireza-sharifpour
Copy link
Member

For the campaign isn't shown I think we should check it with the backend because we show everything we get from the backend

Private Zenhub Image

@mohammadranjbarz @CarlosQ96

@alireza-sharifpour
Copy link
Member

@maryjaf The spacing issue should be fixed.

@maryjaf
Copy link
Collaborator

maryjaf commented Sep 25, 2023

checked with @mohammadranjbarz @alireza-sharifpour now campaign tag is shown only for projects which are added manually to a campaign and @mohammadranjbarz is working on it

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 3, 2023

Plz check this problem in showing tag on mobile project view @alireza-sharifpour

RPReplay_Final1696334923.mp4

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 3, 2023

1-project owner view
Image

I'v checked but there is now change in this pic on stg

@maryjaf
Copy link
Collaborator

maryjaf commented Oct 5, 2023

Plz check this problem in showing tag on mobile project view @alireza-sharifpour

RPReplay_Final1696334923.mp4

Thanks @alireza-sharifpour This problem has been resolved

@maryjaf maryjaf closed this as completed Nov 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants