issues porting from gix 0.66 to 0.67 due to gix::diff::tree::visit::Changes removal

[decathorpe]

I'm trying to port the rustsec crate to a newer version of gix (because we're updating gix in Fedora Linux), and I'm hitting what looks to me like a roadblock:

gix::diff::tree::visit::Changes seems to have been removed without an obvious replacement in gix 0.67+:
https://docs.rs/gix/0.66.0/gix/diff/tree/struct.Changes.html

This is used here:

https://github.com/rustsec/rustsec/blob/bd6fb0fba41246ed860e0e8374d8f31aceabc8f9/rustsec/src/repository/git/modification_time.rs#L114-L130

I have no idea how to do this in gix 0.67+. The changelog only mentions:

Use the new tree_with_rewrites plumbing implementation. This merges object::tree::diff::change::Event into object::tree::diff::Change as well.

https://github.com/GitoxideLabs/gitoxide/blob/main/gix/CHANGELOG.md#refactor-breaking

How is the Recorder supposed to be used in gix 0.67+? I can't find any references to it in the gix docs that show it being used this way any longer, and searching for the string "obtain" doesn't help either.

---

PS: Don't ask me why rustsec uses such old versions of tame-index and gix. The project has dependabot set up, but it doesn't seem to have filed PRs for tame-index / gix updates lately.

[Byron]

I am sorry for the hassle!

Can you point me at a PR that runs into these errors? I could probably patch it up quite swiftly to compile.
Besides that, I tried to show a comparison here between v0.66 and v0.67 which seems to be the first release with the changes, but I couldn't find a forge that could do it (codeberg [doesn't show latest tags]), gitee [needs login], GitHub [unusably slow showing file diffs]). So maybe git diff gix-v0.66.0..gix-v0.67.0 can help.

[decathorpe]

Thanks for the quick response!

This is what I have so far: decathorpe/rustsec@ab3318b

The one necessary code change was easy enough (things no longer taking a buf: &mut Vec, the others look like API removals that aren't obvious how to replace.

error[E0433]: failed to resolve: could not find `Changes` in `tree`
   --> rustsec/src/repository/git/modification_time.rs:115:30
    |
115 |             gix::diff::tree::Changes::from(previous_tree)
    |                              ^^^^^^^ could not find `Changes` in `tree`

error[E0599]: no variant or associated item named `ByCommitTimeNewestFirst` found for enum `gix::gix_traverse::commit::simple::Sorting` in the current scope
  --> rustsec/src/repository/git/modification_time.rs:42:62
   |
42 | ...::simple::Sorting::ByCommitTimeNewestFirst)
   |                       ^^^^^^^^^^^^^^^^^^^^^^^ variant or associated item not found in `Sorting`