Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The newly released (2.0.692) .deb package seems broken #644

Closed
felipecrs opened this issue Apr 1, 2022 · 4 comments · Fixed by #648
Closed

The newly released (2.0.692) .deb package seems broken #644

felipecrs opened this issue Apr 1, 2022 · 4 comments · Fixed by #648

Comments

@felipecrs
Copy link
Contributor

felipecrs commented Apr 1, 2022

@felipecrs felipecrs changed the title The newly released .deb package seems broken The newly released (2.0.692) .deb package seems broken Apr 1, 2022
@felipecrs
Copy link
Contributor Author

I did a quick analysis and I could not find anything useful.

@ldennington
Copy link
Contributor

ldennington commented Apr 2, 2022

Hey @felipecrs - thanks for digging in here. This is not actually a regression from #638 but rather from #630. I haven't been able to root cause what part of that change caused the .deb issue, but I did check out the commit before that series and was able to build with a more normal output package size of 102 MB.

@dscho
Copy link
Collaborator

dscho commented Apr 4, 2022

I wonder whether the root cause lies in here:

@@ -165,10 +181,13 @@ popd

     # Build .deb
     INSTALL_TO="$DEBROOT/usr/local/share/gcm-core/"
-LINK_TO="$DEBROOT/usr/local/bin/"
+    LINK_TO="$DEBROOT/usr/bin/"
     mkdir -p "$DEBROOT/DEBIAN" "$INSTALL_TO" "$LINK_TO" || exit 1

@ldennington
Copy link
Contributor

I spotted this as well on Friday but didn't think that path would affect the size of the generated package. But let me test it out to see!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants