Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geom.ribbon in does not accept Int vectors as input when used with Geom.smooth #559

Closed
espintos opened this issue Mar 10, 2015 · 3 comments · Fixed by #1231
Closed

Geom.ribbon in does not accept Int vectors as input when used with Geom.smooth #559

espintos opened this issue Mar 10, 2015 · 3 comments · Fixed by #1231

Comments

@espintos
Copy link

Geom.ribbon does't accept Int vectors as input for ymin and ymax when used in combination with Geom.smooth.

http://stackoverflow.com/questions/28966555/geom-ribbon-in-gadfly-julia-does-not-accept-int-vectors-as-input

@IainNZ
Copy link
Contributor

IainNZ commented Mar 10, 2015

At a glance, looks like can relax the T to T,S and use a promote_type to keep it type stable

@dcjones
Copy link
Collaborator

dcjones commented Mar 10, 2015

I don't get this error on julia 0.3 or 0.4 on gadfly master. Maybe it's accidentally fixed already?

@Mattriks
Copy link
Member

I can't reproduce this either on Julia 0.5 and Gadfly 0.6, so this issue should be closed?

x = [-10:10;]
y = x.^2
ymin = y-10
ymax = y+10

p = plot(x=x, y=y,  ymin=ymin, ymax=ymax, Geom.smooth, Geom.ribbon)

issue559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants