Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regex not recognize filenames with extra dot in it #59

Open
alex1704 opened this issue Aug 1, 2019 · 3 comments
Open

Regex not recognize filenames with extra dot in it #59

alex1704 opened this issue Aug 1, 2019 · 3 comments
Labels
bug

Comments

@alex1704
Copy link

alex1704 commented Aug 1, 2019

File example:

<html>
<body>
<script src="some-name.anotherone.js"></script>
</body>
</html>

Command:
python linkfinder.py -i s.html -o cli
outputs nothing
Solution:
Changing reqular expression by adding dot to filename regex.
from:
([a-zA-Z0-9_\-]{1,} # filename
to:
([a-zA-Z0-9_\-.]{1,} # filename
@jarombrown
Copy link

I'm having the same issue as @alex1704. Here is a shared regex with the change.

https://regex101.com/r/Oxciyz/2

Still seems to be missing some js files.

@EdOverflow
Copy link
Collaborator

@alex1704 & @jarombrown, please feel free to submit a pull request for this issue if you think your updated regular expression fixes this issue and I will review it.

@EdOverflow EdOverflow added the bug label Aug 26, 2019
@alex1704
Copy link
Author

alex1704 commented Sep 2, 2019

Created - #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alex1704 @jarombrown @EdOverflow