Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement russian language into the game #63

Merged
merged 7 commits into from
Nov 17, 2020
Merged

Implement russian language into the game #63

merged 7 commits into from
Nov 17, 2020

Conversation

BurAndBY
Copy link

@BurAndBY BurAndBY commented Nov 16, 2020 •
edited
Loading

@BurAndBY BurAndBY changed the title Release Implement russian language into the game Nov 16, 2020
@BurAndBY
Copy link
Author

I don't sure this is working lol. ### My programming skills are 0

@cypress
Copy link

cypress bot commented Nov 16, 2020 •
edited
Loading


Test summary

2 • 0 • 0 • 0

Run details
Project Geoguess
Status Passed
Commit 747cf9c ℹ️
Started Nov 17, 2020 8:45 PM
Ended Nov 17, 2020 8:45 PM
Duration 00:39 💡
OS Linux Ubuntu - 16.04
Browser Chrome 86

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

BilelJegham
BilelJegham requested changes Nov 16, 2020
View reviewed changes
Copy link
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @BurAndBY, some strings aren't translated. Can you check it ?

@BurAndBY
Copy link
Author

BurAndBY commented Nov 17, 2020 •
edited
Loading

https://pastebin.com/NdYTL1g4 Pastebin
TranslationsRU.zip edited

@BurAndBY
Copy link
Author

Thanks @BurAndBY, some strings aren't translated. Can you check it?

FIXED

@codecov-io
Copy link

codecov-io commented Nov 17, 2020 •
edited
Loading

Codecov Report

Merging #63 (fc22677) into master (d47a746) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage   21.81%   21.91%   +0.10%     
==========================================
  Files          23       23              
  Lines         729      730       +1     
  Branches      118      118              
==========================================
+ Hits          159      160       +1     
  Misses        570      570
Impacted Files Coverage Δ
src/components/home/Header.vue 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d47a746...fc22677. Read the comment docs.

@BilelJegham BilelJegham merged commit ab1284f into master Nov 17, 2020
@BilelJegham BilelJegham deleted the release branch November 17, 2020 21:12
@BilelJegham
Copy link
Member

@all-contributors please add @BurAndBY for translation

@allcontributors allcontributors bot mentioned this pull request Nov 24, 2020
Merged
@allcontributors
Copy link
Contributor

@BilelJegham

I've put up a pull request to add @BurAndBY! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BilelJegham BilelJegham BilelJegham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BurAndBY @codecov-io @BilelJegham