Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/details random point #56

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Conversation

BilelJegham
Copy link
Member

@BilelJegham BilelJegham commented Nov 11, 2020

Adding details of the position.

FormatGeoJSON

{"type":"FeatureCollection","features":[
{
   "type":"Feature",
    "geometry":...,
     "properties":{
           "title": *string* | *object*,
            "description":*string* | *object*,
            "link":*string*,
       }
}
]}

interface object {
    [languageInital: string]: string
}

Example :

{
    "type": "FeatureCollection",
    "features": [{
        "type": "Feature",
        "geometry": {
            "type": "Point",
            "coordinates": [2.0104348, 42.4411844]
        },
        "properties": {
            "title": "Sainte-Léocadie",
            "description": {
                "fr": "un ville",
                "en": "a city"
            },
            "link": "http://www.sainte-leocadie.fr/"
        }
    }]
}
Loading

Screenshots :

image

Map exemple

French station (source https://ressources.data.sncf.com/) https://gist.githubusercontent.com/BilelJegham/891f976fac2017ae19e699991aba4f01/raw/19bfe072be8762e93142b56eddecf83b967f7d9d/referentiel-gares-voyageurs-min.geojson

@codecov-io
Copy link

codecov-io commented Nov 11, 2020

Codecov Report

Merging #56 (c6f00ec) into master (b4ef456) will decrease coverage by 0.37%.
The diff coverage is 58.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   22.70%   22.33%   -0.38%     
==========================================
  Files          21       21              
  Lines         709      712       +3     
  Branches      118      116       -2     
==========================================
- Hits          161      159       -2     
- Misses        548      553       +5     
Impacted Files Coverage Δ
src/components/Maps.vue 0.00% <0.00%> (ø)
src/pages/StreetView.vue 0.00% <0.00%> (ø)
src/components/home/DialogCustomMap.vue 32.25% <100.00%> (+7.25%) ⬆️
src/store/homeStore.js 93.44% <100.00%> (-0.77%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4ef456...c6f00ec. Read the comment docs.

@cypress
Copy link

cypress bot commented Nov 11, 2020



Test summary

2 0 0 0


Run details

Project Geoguess
Status Passed
Commit 0373791 ℹ️
Started Nov 11, 2020 9:41 PM
Ended Nov 11, 2020 9:42 PM
Duration 00:29 💡
OS Linux Ubuntu - 16.04
Browser Chrome 86

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@BilelJegham BilelJegham added this to the v0.2 milestone Nov 11, 2020
@BilelJegham BilelJegham linked an issue Nov 11, 2020 that may be closed by this pull request
@BilelJegham BilelJegham marked this pull request as ready for review November 11, 2020 21:45
@BilelJegham BilelJegham merged commit d4a336c into master Nov 12, 2020
@BilelJegham BilelJegham deleted the feature/detailsRandomPoint branch November 13, 2020 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display information once the round results are displayed
3 participants