Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix several small bugs #45

Merged
merged 7 commits into from
Oct 5, 2020
Merged

fix several small bugs #45

merged 7 commits into from
Oct 5, 2020

Conversation

simonrousseau
Copy link
Member

No description provided.

BilelJegham
BilelJegham requested changes Oct 4, 2020
View reviewed changes
Copy link
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great

Maybe had in this PR worlkflow Github Action with eslint to check code.

@simonrousseau
Copy link
Member Author

@BilelJegham eslint and prettier have been added to format and uniformise codebase

@simonrousseau
Copy link
Member Author

@BilelJegham All eslint errors have been fixed
Can you please merge this pull request before starting new developments ;)

@simonrousseau simonrousseau reopened this Oct 5, 2020
BilelJegham
BilelJegham approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@BilelJegham BilelJegham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great merge

@BilelJegham BilelJegham merged commit 71369a2 into master Oct 5, 2020
@BilelJegham BilelJegham deleted the fix-corrections branch October 9, 2020 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BilelJegham BilelJegham BilelJegham approved these changes

Assignees

@BilelJegham BilelJegham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@simonrousseau @BilelJegham