Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Receipts List/Admin] - Add a comment field for expense rejection #22

Open
2 tasks
AleHundred opened this issue Jan 26, 2020 · 2 comments
Open
2 tasks

Comments

@AleHundred
Copy link
Collaborator

When reviewing expenses, some may be marked invalid for reasons that are not necessarily tied to their legality, so it would be a more precise user experience to remove that wording to avoid confusion as well as adding a new field so that the uploader knows why it was rejected.

  • Remove the word "legally" from "Mark legally valid/invalid" buttons
  • Add a comment field so the expense uploader knows why it was marked invalid if that's the case.
@AleHundred AleHundred changed the title [Expenses List/Admin] - Add a comment field for expense rejection [Receipts List/Admin] - Add a comment field for expense rejection Jan 26, 2020
@chmac
Copy link
Collaborator

chmac commented Feb 1, 2020

@AlxSavage The idea was that we would check to make sure that the invoice meets all the German bureaucratic requirements. I like the concept of a comment to explain why, that's a neat idea.

@chmac
Copy link
Collaborator

chmac commented Feb 1, 2020

PS> I'm not sure I'd remove the label from the legally valid part. I guess we could also add another type of rejection if that was necessary. Or maybe that's overcomplicating, not sure! :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants