-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing colorbars in examples #2030
Comments
I agree with you on both examples. Ping the original authors for comments before making the changes @willschlitzer @weiji14. |
May I ask what the status of this issue is? Meaning, is it welcome by the original authors @willschlitzer and @weiji14 that colorbars are added to their examples, or should these two examples remain unchanged? In the first case, is it fine that I work on this, if I have time? Or do you prefer to make these changes on your own, which is of course totally fine for me? |
Oh yes, you are welcome to add colorbars to both examples. Let me assign you to the issue, and thanks for volunteering to help out! |
Thanks @weiji14. Is it fine, if I split this issue into two PRs, one per example? |
Two in one PR should be fine for this. |
Original posts by @weiji14 (#2190 (review)) and @seisman (#2190 (comment)) regarding gallery example
Perhaps we can rewrite the grdtrack example to something like (https://docs.gmt-china.org/latest/examples/ex026/): |
Probably better to mention the |
Yep, sure, please see #2282. |
In two examples a colormap is used but the corresponding colorbar is missing.
This limits the interpretability of the figures (especially for Sampling along tracks). Thus, I think a colorbar should be added.
The text was updated successfully, but these errors were encountered: