Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing colorbars in examples #2030

Closed
Tracked by #2244
yvonnefroehlich opened this issue Jul 28, 2022 · 8 comments · Fixed by #2190
Closed
Tracked by #2244

Missing colorbars in examples #2030

yvonnefroehlich opened this issue Jul 28, 2022 · 8 comments · Fixed by #2190
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@yvonnefroehlich
Copy link
Member

In two examples a colormap is used but the corresponding colorbar is missing.

This limits the interpretability of the figures (especially for Sampling along tracks). Thus, I think a colorbar should be added.

@seisman seisman added the documentation Improvements or additions to documentation label Jul 30, 2022
@seisman seisman added this to the 0.8.0 milestone Jul 30, 2022
@seisman
Copy link
Member

seisman commented Jul 30, 2022

I agree with you on both examples. Ping the original authors for comments before making the changes @willschlitzer @weiji14.

@yvonnefroehlich
Copy link
Member Author

May I ask what the status of this issue is? Meaning, is it welcome by the original authors @willschlitzer and @weiji14 that colorbars are added to their examples, or should these two examples remain unchanged? In the first case, is it fine that I work on this, if I have time? Or do you prefer to make these changes on your own, which is of course totally fine for me?

@weiji14
Copy link
Member

weiji14 commented Sep 18, 2022

Oh yes, you are welcome to add colorbars to both examples. Let me assign you to the issue, and thanks for volunteering to help out!

@yvonnefroehlich
Copy link
Member Author

Oh yes, you are welcome to add colorbars to both examples. Let me assign you to the issue, and thanks for volunteering to help out!

Thanks @weiji14. Is it fine, if I split this issue into two PRs, one per example?

@weiji14
Copy link
Member

weiji14 commented Sep 19, 2022

Oh yes, you are welcome to add colorbars to both examples. Let me assign you to the issue, and thanks for volunteering to help out!

Thanks @weiji14. Is it fine, if I split this issue into two PRs, one per example?

Two in one PR should be fine for this.

@yvonnefroehlich
Copy link
Member Author

Original posts by @weiji14 (#2190 (review)) and @seisman (#2190 (comment)) regarding gallery example track_sampling.py

The original intention of the track_sampling.py gallery example added in #308 was to showcase the grdtrack data processing function, rather than as a proper 'map' per se.

Personally, I feel that having just one colorbar (the normalized elevation one) would be enough, since the background grayscale earth_relief elevation is just for context. But I also find normalized elevation to be hard to interpret (see my comment below), so not sure what's a good plan forward 😅 What are your thoughts?

Perhaps we can rewrite the grdtrack example to something like (https://docs.gmt-china.org/latest/examples/ex026/):
image

@weiji14
Copy link
Member

weiji14 commented Dec 28, 2022

Probably better to mention the grdtrack gallery example redesign in a separate issue. Can you open one @yvonnefroehlich?

@yvonnefroehlich
Copy link
Member Author

Probably better to mention the grdtrack gallery example redesign in a separate issue. Can you open one @yvonnefroehlich?

Yep, sure, please see #2282.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants