-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move parts of the contributing guides to the website #1205
Comments
I feel we could move all of them to the documentation instead of putting them in two places. We could re-group the guides into basic and advanced ones as your suggestion. In this way, experienced contributors could still quickly find what they need, while new contributors can also know all the things in one place. |
I like scikit-learn's stucture, which has a minimal CONTRIBUTING.md that primarily provides links to the contributing guides on their website. I prefer to keep some sort of CONTRIBUTING.md because people interested in contributing could do a quick search for it and I would not want to risk losing any potential contributors due to its absence. |
Yes, I agree we should at least have a minimal CONTRIBUTING.md file. |
If we want a minimal CONTRIBUTING.md, how about the following TOC of
Meanwhile, we could move all the sections to the website. |
I will open a PR based on the conversation here, because if possible it would be nice to get this in for v0.4.0 in advance of the July/August sprint/workshop. |
In PR #1185, we moved the maintainer's guides to the documentation (the
doc
directory), since the guides are too long and are much easier to read on the documentation website (using the sidebar links).Similarly, the contributing guides is also too long, with more than 500 lines now, and still increasing (#1119, #1113).
I don't think it's a good idea to move the whole CONTRIBUTING.md file to the documentation. Instead, I think we can only keep basic guides in the repository, but move advanced guides to the documentation.
Basic guides are mainly for first-time contributors or people who are not familiar with github workflows (it means people like me will never read it). IMHO, basic guides can include sections like:
Other sections like rules/styles of our documentation and code, instructions to run tests and generate baseline images, are too technical and can be grouped as advanced guides (even people like me need to read it sometimes).
This is just a quick idea, and I'm not sure if it would cause more confusion, but I'd like to hear your thoughts.
The text was updated successfully, but these errors were encountered: