Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring back ADCS #61

Open
smallketchup82 opened this issue Aug 21, 2024 · 1 comment
Open

Bring back ADCS #61

smallketchup82 opened this issue Aug 21, 2024 · 1 comment
Assignees
Labels
priority:high needs to be worked on asap

Comments

@smallketchup82
Copy link
Member

smallketchup82 commented Aug 21, 2024

I never really used it since it was rather premature, but it was a good idea in practice (you'd have an always up-to-date dataset). We should bring it back, but I'm a little split on implementation.

I would want ADCS to be a class. But at the same time, I don't want galaxygpt to have a reference dependency on dataset-assistant, since it's meant to be a utility.

But at the same time, I don't want to have to copy-paste the code from dataset-assistant into galaxygpt.

I can only see a couple ways of properly implementing this:

  1. Make ADCS a seperate project. Have it depend on dataset-assistant. Maybe add quartz.net to it for scheduling.
  2. Decouple the dataset creation code from dataset-assistant, put it in galaxygpt, then have dataset-assistant depend on galaxygpt's DatasetCreator class. And bake ADCS into galaxygpt.
  3. Combine both solutions. Have ADCS be a seperate project, but instead of referencing dataset-assistant, decouple the dataset creation logic from dataset-assistant and put it in galaxygpt. Then have ADCS depend on galaxygpt's DatasetCreator class.
@smallketchup82 smallketchup82 self-assigned this Aug 21, 2024
@smallketchup82 smallketchup82 added the priority:low good to have at some point label Aug 28, 2024
@smallketchup82 smallketchup82 added this to the Semi-Public Release milestone Sep 26, 2024
@smallketchup82 smallketchup82 added priority:high needs to be worked on asap and removed type:enhancement priority:low good to have at some point labels Oct 3, 2024
@smallketchup82
Copy link
Member Author

as an update to this, i had long ago added the db infra needed for this. previously the mariadb database that comet uses was only exposed via unix socket, not tcp/ip. this meant that only really comet could access mariadb, nothing else.

a while ago i made a change where i enabled tcp/ip alongside unix socket. the galaxypedia connects through the socket since it's on comet, and benefits from the added speed and security of it. on the other hand, i used ufw to allow tailscale access to the mariadb port, but nothing else.

meaning the tailscale network that i run should provide access to to the database, and galaxygpt (which is on ketchupdesktop) should be able to communicate to the database over wireguard where communication is end-to-end encrypted.

the only thing that's left is to add in the galaxygpt-sided infrastructure. i believe that it'd be better to go route 2 from the OP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high needs to be worked on asap
Projects
None yet
Development

No branches or pull requests

1 participant