Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QA Design Landing Page (Bold Text and Space) #2014

Closed
fongcindy opened this issue Dec 19, 2024 · 2 comments · Fixed by #2020
Closed

QA Design Landing Page (Bold Text and Space) #2014

fongcindy opened this issue Dec 19, 2024 · 2 comments · Fixed by #2020
Assignees
Labels
V1 Final V1 handoff work

Comments

@fongcindy
Copy link

fongcindy commented Dec 19, 2024

Design file

Domain

design

Related Issue(s)

Bolding of text "We do not share, save, or submit"

Live site:
image

Expected:
image

Extra space between the CTA and footer section. This space is 56 to 60px

Live site:
image

Expected:
image

Description

No response

@scottqueen-bixal
Copy link
Contributor

@ErnestoFernandezAlvarez

on this comment:

Extra space between the CTA and footer section. This space is 56 to 60px

Live site:
image

Expected:
image

.main and .usa-footer both have 32px of padding. for a combined 64px that are not styles we control.

I can remove any margin and padding on intro below our button and our application wrapper, but I really have no control over the css in those other global spaces.

We would need to propose style changes with usagov to remove these global stylings from our pages to meet your requirements on these measurement.

I am not against this tbh, I've always disliked this random white space we experience from this issue:

Image

If you want to move forward with this, please break this request out into a new ticket so I can work with usagov in the new year to get approval from their dev team.

cc: @fongcindy

@ErnestoFernandezAlvarez

This ticket has been resolved
Thank you @scottqueen-bixal

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V1 Final V1 handoff work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants