Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove data-analytic* attributes from DOM #1507

Closed
2 tasks
scottqueen-bixal opened this issue Jun 27, 2024 · 3 comments · Fixed by #1889
Closed
2 tasks

Remove data-analytic* attributes from DOM #1507

scottqueen-bixal opened this issue Jun 27, 2024 · 3 comments · Fixed by #1889
Assignees
Labels
V1 Final V1 handoff work
Milestone

Comments

@scottqueen-bixal
Copy link
Contributor

scottqueen-bixal commented Jun 27, 2024

Description

We have moved to consistently using the dataLayer for pushing custom events, and are including the values that were previously in the data-attributes* in those objects.

It would be better to remove these attributes so they are no longer in the DOM

User Story

As a developer I would like to centralize data structure and values into dataLayer custom events rather than DOM attributes

As a data analyst I expect to see tracking values in the dataLayer rather than in the DOM attributes

Acceptance Criteria

  • data attributes for analytics are removed from the DOM
  • includes, data-analytics and data-analytics-content only
@nickpistone
Copy link

The tags using the data-analytics* attributes have been removed from GTM, so there is nothing relying on them. To clarify, we are talking about two attributes (data-analytics and data-analytics-content), right @scottqueen-bixal ? Are there any other attributes that fall into that category that I'm missing?

@scottqueen-bixal
Copy link
Contributor Author

Thanks for the update @nickpistone. This is exactly the confirmation that we need to remove those attributes from our DOM rendering.

As far as I am aware you are correct, data-analytics and data-analytics-content will be the two attributes that will be removed with the completion of this work.

I've updated the AC to clarify. 👍

@nickpistone
Copy link

Verified that this is no longer showing up in Dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V1 Final V1 handoff work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants