Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various hardcoded NUM_VARS which break when applied to diagnostics #129

Closed
mirenradia opened this issue Jul 8, 2020 · 1 comment · Fixed by #131
Closed

Various hardcoded NUM_VARS which break when applied to diagnostics #129

mirenradia opened this issue Jul 8, 2020 · 1 comment · Fixed by #131
Assignees
Labels
bug Something isn't working

Comments

@mirenradia
Copy link
Member

mirenradia commented Jul 8, 2020

There are several pieces of code that have NUM_VARS hardcoded which one might wish to use for diagnostics from #119 . Some of the ones I have found so far:

@mirenradia mirenradia added the bug Something isn't working label Jul 8, 2020
@mirenradia mirenradia self-assigned this Jul 8, 2020
@mirenradia
Copy link
Member Author

Also we need to update the parameter files for some of the examples which still specify the asymptotic boundary values (in the case of Sommerfeld BCs) for variables which are now diagnostics.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant