From 42ab1da73499d2fbfbeb2184f053eb313fecc8ca Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Blanka=20Ga=C3=A1l?= <147269155+GBlanka@users.noreply.github.com> Date: Fri, 20 Oct 2023 19:13:49 +0200 Subject: [PATCH 1/4] Update pybamm/models/submodels/interface/sei/base_sei.py changes to base_sei Co-authored-by: Eric G. Kratz --- pybamm/models/submodels/interface/sei/base_sei.py | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/pybamm/models/submodels/interface/sei/base_sei.py b/pybamm/models/submodels/interface/sei/base_sei.py index 45bade57e4..2bf15aa5f0 100644 --- a/pybamm/models/submodels/interface/sei/base_sei.py +++ b/pybamm/models/submodels/interface/sei/base_sei.py @@ -97,16 +97,10 @@ def _get_standard_thickness_variables(self, L_inner, L_outer): } ) # Get variables related to the total thickness - if self.single_layer_sei: - # In case of single layer SEI - # Inner layer is usually set to zero - L_sei = L_outer - variables.update(self._get_standard_total_thickness_variables(L_sei)) - - else: - # In case of two SEI layers + L_sei = L_outer + if not self.single_layer_sei: L_sei = L_inner + L_outer - variables.update(self._get_standard_total_thickness_variables(L_sei)) + variables.update(self._get_standard_total_thickness_variables(L_sei)) return variables From 496362428db08a304d370e6ffa4e44d1cc6909af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Blanka=20Ga=C3=A1l?= <147269155+GBlanka@users.noreply.github.com> Date: Fri, 20 Oct 2023 19:17:06 +0200 Subject: [PATCH 2/4] Update pybamm/models/submodels/interface/sei/base_sei.py Co-authored-by: Eric G. Kratz --- pybamm/models/submodels/interface/sei/base_sei.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pybamm/models/submodels/interface/sei/base_sei.py b/pybamm/models/submodels/interface/sei/base_sei.py index 2bf15aa5f0..87749e4def 100644 --- a/pybamm/models/submodels/interface/sei/base_sei.py +++ b/pybamm/models/submodels/interface/sei/base_sei.py @@ -196,7 +196,6 @@ def _get_standard_concentration_variables(self, variables): n_SEI = n_inner + n_outer # SEI concentration - # Same calculation for both cases n_SEI_xav = pybamm.x_average(n_SEI) n_SEI_av = pybamm.yz_average(n_SEI_xav) From f08202958d0a32a3adc2c37487db6690c3b9d43a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Blanka=20Ga=C3=A1l?= <147269155+GBlanka@users.noreply.github.com> Date: Fri, 20 Oct 2023 19:17:34 +0200 Subject: [PATCH 3/4] Update pybamm/models/submodels/interface/sei/base_sei.py Co-authored-by: Eric G. Kratz --- pybamm/models/submodels/interface/sei/base_sei.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pybamm/models/submodels/interface/sei/base_sei.py b/pybamm/models/submodels/interface/sei/base_sei.py index 87749e4def..80838fe8c7 100644 --- a/pybamm/models/submodels/interface/sei/base_sei.py +++ b/pybamm/models/submodels/interface/sei/base_sei.py @@ -269,7 +269,6 @@ def _get_standard_concentration_variables(self, variables): n_SEI_cr = n_inner_cr + n_outer_cr # SEI on cracks concentration - # Same calculation for both cases n_SEI_cr_xav = pybamm.x_average(n_SEI_cr) n_SEI_cr_av = pybamm.yz_average(n_SEI_cr_xav) From 91ae167d6af11c160314c93bab63b34ed4367969 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Blanka=20Ga=C3=A1l?= <147269155+GBlanka@users.noreply.github.com> Date: Fri, 20 Oct 2023 19:18:00 +0200 Subject: [PATCH 4/4] Update pybamm/models/submodels/interface/sei/base_sei.py Co-authored-by: Eric G. Kratz --- pybamm/models/submodels/interface/sei/base_sei.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pybamm/models/submodels/interface/sei/base_sei.py b/pybamm/models/submodels/interface/sei/base_sei.py index 80838fe8c7..296777f76a 100644 --- a/pybamm/models/submodels/interface/sei/base_sei.py +++ b/pybamm/models/submodels/interface/sei/base_sei.py @@ -343,7 +343,6 @@ def _get_standard_reaction_variables(self, j_inner, j_outer): The variables which can be derived from the SEI currents. """ domain, Domain = self.domain_Domain - # Case for a single layer if self.single_layer_sei: j_sei = j_outer j_sei_xav = pybamm.x_average(j_sei)