[VirtualizationServerController2012] Error while converting VHD: Thread was being aborted.

[berkut1]

Describe the bug

Error while converting VHD: Thread was being aborted.
Thread was being aborted.
at System.Threading.Thread.SleepInternal(Int32 millisecondsTimeout)
at System.Threading.Thread.Sleep(Int32 millisecondsTimeout)
at SolidCP.EnterpriseServer.VirtualizationServerController2012.JobCompleted(VirtualizationServer2012 vs, ConcreteJob job)
at SolidCP.EnterpriseServer.VirtualizationServerController2012.CreateVirtualMachineInternal(String taskId, VirtualMachine vm, LibraryItem osTemplate, Int32 externalAddressesNumber, Boolean randomExternalAddresses, Int32[] externalAddresses, Int32 privateAddressesNumber, Boolean randomPrivateAddresses, String[] privateAddresses, String summaryLetterEmail)
Unhandled error while creating VPS: Thread was being aborted.
Thread was being aborted.
at SolidCP.EnterpriseServer.VirtualizationServerController2012.CreateVirtualMachineInternal(String taskId, VirtualMachine vm, LibraryItem osTemplate, Int32 externalAddressesNumber, Boolean randomExternalAddresses, Int32[] externalAddresses, Int32 privateAddressesNumber, Boolean randomPrivateAddresses, String[] privateAddresses, String summaryLetterEmail)
VPS was not created

Possible solution
Wrap the JobCompleted function in a try catch and if we get an exception, check the JobState, if JobState is fine then continue, if not, then complete the task and show an error.

To Reproduce
random

SolidCP Info

• SolidCP Version: any

---

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[berkut1]

This issue still exist.
After thread aborted need to reactivate it, or we still get exception (as unhandled) if try to get job state

SolidCP/SolidCP/Sources/SolidCP.EnterpriseServer.Code/Virtualization2012/Helpers/JobHelper.cs

Line 30 in 5a9b928

job = vs.GetJob(job.Id); //get the last job state

Should we use Thread.ResetAbort(); ?

Need find a way how to test the best solution.