Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PeerReportBehavior functionality to FuelBehavior #1561

Closed
MitchTurner opened this issue Dec 18, 2023 · 2 comments
Closed

Move PeerReportBehavior functionality to FuelBehavior #1561

MitchTurner opened this issue Dec 18, 2023 · 2 comments

Comments

@MitchTurner
Copy link
Member

In our upgrading of libp2p we moved identify and heartbeat out of PeerReportBehavior and into the FuelBehavior. There is still some functionality left in the PeerReportBehavior, however that probably can be moved to FuelBehavior.

We can just get rid of PeerReport all together, probably 👍
@MitchTurner MitchTurner mentioned this issue Dec 18, 2023
Merged
@matt-user matt-user mentioned this issue Jun 6, 2024
Closed
9 tasks
@MitchTurner
Copy link
Member Author

We made an initial attempt at this in #1944 but ran into issues with adding custom fields in the #[derive(NetworkBehavior)]. I think we need to reevaluate how our libp2p code is architectured from a high level and that will help us decide how to deal with this issue.

@MitchTurner
Copy link
Member Author

Replacing with #2223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: peer report FuelLabs/fuel-core
1 participant
@MitchTurner