You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.
Currently the HTML and CSS is written manually and lack the possibility for easy styling and modifying like normal templating in Shopware (smarty, less, snippets).
Actual behaviour
Currently the notice is injected after the response is rendered. The notice is generated by constant HTML pattern and some database information. This is uneasy to maintain and extend.
Expected behaviour
I want to style the notice with the current Shopware stack. This should be easy for versioning and extending by using the Shopware templating stack.
To maintain functionality of this plugin when exceptions in the templating stack occur there should be a plain fallback that point to the exceptions.
Checklist
I have checked all issues and haven't found a similar report.
I am using the latest stable version of this plugin.
The text was updated successfully, but these errors were encountered:
I added the events Frosh_EnvironmentNotice_NoticeMarkupBuilder_prepareView to add template directories and Frosh_EnvironmentNotice_NoticeMarkupBuilder_prepareViewData to filter the data that is passed into the view. The less variables is based on the selected themes. Mixins-support is missing as I am not sure what is the best way to get the right include path to the Bare theme.
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Currently the HTML and CSS is written manually and lack the possibility for easy styling and modifying like normal templating in Shopware (smarty, less, snippets).
Actual behaviour
Currently the notice is injected after the response is rendered. The notice is generated by constant HTML pattern and some database information. This is uneasy to maintain and extend.
Expected behaviour
I want to style the notice with the current Shopware stack. This should be easy for versioning and extending by using the Shopware templating stack.
To maintain functionality of this plugin when exceptions in the templating stack occur there should be a plain fallback that point to the exceptions.
Checklist
The text was updated successfully, but these errors were encountered: