Skip to content
This repository has been archived by the owner on Jun 18, 2020. It is now read-only.

Use Shopware templating stack while still injecting the notices #1

Open
2 tasks done
JoshuaBehrens opened this issue Jun 17, 2018 · 1 comment
Open
2 tasks done
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@JoshuaBehrens
Copy link
Contributor

JoshuaBehrens commented Jun 17, 2018

Currently the HTML and CSS is written manually and lack the possibility for easy styling and modifying like normal templating in Shopware (smarty, less, snippets).

Actual behaviour

Currently the notice is injected after the response is rendered. The notice is generated by constant HTML pattern and some database information. This is uneasy to maintain and extend.

Expected behaviour

I want to style the notice with the current Shopware stack. This should be easy for versioning and extending by using the Shopware templating stack.
To maintain functionality of this plugin when exceptions in the templating stack occur there should be a plain fallback that point to the exceptions.

Checklist

  • I have checked all issues and haven't found a similar report.
  • I am using the latest stable version of this plugin.
@JoshuaBehrens JoshuaBehrens added enhancement New feature or request help wanted Extra attention is needed labels Jun 17, 2018
@JoshuaBehrens JoshuaBehrens self-assigned this Aug 13, 2018
@JoshuaBehrens
Copy link
Contributor Author

JoshuaBehrens commented Aug 13, 2018

Branch https://github.com/FriendsOfShopware/FroshEnvironmentNotice/tree/feature/templating

I added the events Frosh_EnvironmentNotice_NoticeMarkupBuilder_prepareView to add template directories and Frosh_EnvironmentNotice_NoticeMarkupBuilder_prepareViewData to filter the data that is passed into the view. The less variables is based on the selected themes. Mixins-support is missing as I am not sure what is the best way to get the right include path to the Bare theme.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant