Skip to content

Commit

Permalink
minor #5204 DX: cleanup NullableTypeTransformerTest (kubawerlos)
Browse files Browse the repository at this point in the history
This PR was merged into the 2.15 branch.

Discussion
----------

DX: cleanup NullableTypeTransformerTest

Took me a minute to figure out that this is actually the same test. Let's save that from another person who spots this.

Pinging @julienfalque (as an author of `testProcess74` function) and @julienfalque (as an author of `testProcessPhp74` function) for review 😃

Commits
-------

08da4d2 DX: cleanup NullableTypeTransformerTest
  • Loading branch information
SpacePossum committed Oct 27, 2020
2 parents 80aa495 + 08da4d2 commit 7996eea
Showing 1 changed file with 0 additions and 23 deletions.
23 changes: 0 additions & 23 deletions tests/Tokenizer/Transformer/NullableTypeTransformerTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -118,29 +118,6 @@ public function provideProcess74Cases()
9 => CT::T_NULLABLE_TYPE,
],
],
];
}

/**
* @param string $source
*
* @dataProvider provideProcessPhp74Cases
* @requires PHP 7.4
*/
public function testProcessPhp74($source, array $expectedTokens = [])
{
$this->doTest(
$source,
$expectedTokens,
[
CT::T_NULLABLE_TYPE,
]
);
}

public function provideProcessPhp74Cases()
{
return [
[
'<?php fn(?Barable $barA, ?Barable $barB): ?Fooable => null;',
[
Expand Down

0 comments on commit 7996eea

Please sign in to comment.