-
Notifications
You must be signed in to change notification settings - Fork 900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problems with Unicode characters #856
Comments
Where are you even finding this stuff? Regarding the exiting of HTML boundaries, it would be important to see how these are actually clipped with CSS and then implement a working solution for it. I would imagine that stopping the text somewhere, showing a ... and then having an overlay which appears when you hover over the text would fit the best here. For the moment I'd suggest not searching for this character? I mean, I didn't even know this character existed in the first place. |
Do u want me to add hyperlinks to the specific pages?
I used this character for creating extreme examples (just for the principle of it) to make u aware of these problems (before yesterday i also didn't know these kind of characters existed). |
Having the links to them do help. Like was mentioned, these are fairly extreme examples but it wouldn't hurt to do better checks for cases like these. The issue seems to be more of an issue with long strings of text with no whitespace than with the characters themselves. In theory these should be simple CSS fixes but I won't know until I look at them closer. |
Hyperlinks are added at the screenshots. |
@PrestonN @GilgusMaximus would it be better if i split this issue up into twelve issues? For each problem i found one issue. I think contributors would start with an issue faster when its not this big, because they think its maybe easier. I think contributors get a little scared of all the things i summed up here. |
Not really. Basically the underlying problem is that some obscure characters become so long that they do not fit into the html boxes correctly. |
@GilgusMaximus Okay no problem. Just added 9 more problems :( |
img no. 8 is referenced in the above issue ^ |
Note to self: Restest issue and convert to proper feature request |
Converted #4284 |
Is your feature request related to a usage problem (not a bug)? Please describe.
So i did some further investigation on Unicode characters and i found out that people can use Unicode characters everywhere on YouTube (I used this 𒐫 Unicode character in my research).
I found out the following things (All of these things have corresponding screenshots):
The following applies for these pages Subscriptions, Trending, Most Popular, Playlist, History, Search and Profile page with the setting enabled view video type = grid
The following applies for the Video player page.
The following applies for the Comment section on the Video player page.
The following applies for the Up next section on the Video player page.
The following applies for the Channel page.
The following applies for the Playlist page.
The following applies for the Playlist section on the video page.
The following applies for these pages Subscriptions, Trending, Most Popular, Playlist, History, Search and Profile page with the setting enabled view video type = list
Describe the solution you'd like to see implemented (Some of the 'solutions' have corresponding screenshots)
Describe alternatives/optional things you've considered (All the 'alternatives' have corresponding screenshots)
Screenshots (Dark theme is FreeTube and Light theme is YouTube Solution / Alternative)
https://www.youtube.com/results?search_query=%F0%92%90%AB+
![Screenshot (12)](https://user-images.githubusercontent.com/73130443/101696248-bc4de580-3a6d-11eb-8b75-9b59caaa5447.png)
https://www.youtube.com/results?search_query=%F0%92%90%AB+
![Capture](https://user-images.githubusercontent.com/73130443/101697209-4d718c00-3a6f-11eb-926a-b7ea6ffa05f5.PNG)
Alternative:
![Screenshot (14)](https://user-images.githubusercontent.com/73130443/101697224-595d4e00-3a6f-11eb-9233-17ec1e115167.png)
https://www.youtube.com/results?search_query=%F0%92%90%AB+
![Capture](https://user-images.githubusercontent.com/73130443/101697733-41d29500-3a70-11eb-928d-23645e91de89.PNG)
Best way to find this is to search 𒐫 with filter Type: Videos enabled
![Capture](https://user-images.githubusercontent.com/73130443/119910414-a1512e00-bf46-11eb-95a8-8e1d686f272e.PNG)
https://youtu.be/mAMdleRNTjk
![Capture](https://user-images.githubusercontent.com/73130443/101698102-df2dc900-3a70-11eb-8cfa-489fcdc1fd91.PNG)
YT solution:
![Capture1](https://user-images.githubusercontent.com/73130443/101698106-dfc65f80-3a70-11eb-9685-b2bc534f9754.PNG)
https://youtu.be/gSlhGZg4Kfc
![Capture](https://user-images.githubusercontent.com/73130443/101698724-ea352900-3a71-11eb-9ee8-297f7dd96e46.PNG)
https://youtu.be/lf2kONhTdoE
![Capture](https://user-images.githubusercontent.com/73130443/101699365-ea81f400-3a72-11eb-8090-e750ca41886f.PNG)
YT solution:
![Capture1](https://user-images.githubusercontent.com/73130443/101699381-f40b5c00-3a72-11eb-8aa4-9bc552860436.PNG)
https://youtu.be/ta67rqaSVnc
![Capture](https://user-images.githubusercontent.com/73130443/119913130-a5804a00-bf4c-11eb-97d3-9344bbf72e5c.PNG)
https://www.youtube.com/watch?v=aXqt-10pWpw
![Capture](https://user-images.githubusercontent.com/73130443/122593256-eb649580-d054-11eb-9f59-d43cc9827913.PNG)
https://youtu.be/UAj01-6lWD8
![Capture](https://user-images.githubusercontent.com/73130443/101761079-a2df8480-3ad3-11eb-98de-52d8633e2e62.PNG)
https://youtu.be/UAj01-6lWD8
![Capture](https://user-images.githubusercontent.com/73130443/101761651-56487900-3ad4-11eb-8cf6-47f98002b74f.PNG)
(Well its not the same comment but you'll get the principle)
YT solution:
![Capture1](https://user-images.githubusercontent.com/73130443/101761699-61030e00-3ad4-11eb-8687-f7e7ea445172.PNG)
https://youtu.be/oL59ryNVaXk
![Capture](https://user-images.githubusercontent.com/73130443/101695207-21084080-3a6c-11eb-9140-a160a0f5ec72.PNG)
![Capture1](https://user-images.githubusercontent.com/73130443/101695216-236a9a80-3a6c-11eb-949b-991eb477c012.PNG)
https://www.youtube.com/channel/UCYjRiR2FeyxpROu3laVWo_Q
![Capture](https://user-images.githubusercontent.com/73130443/101701523-fa9bd280-3a76-11eb-8da7-daa252b57448.PNG)
(Go to his channel > watch a vid > check the up next section > if u dont see it > go back to his channel and watch a other vid > check up next section > repeat procedure untill u get the result)
I couldn't find an example for this so i edited this with the developer tools.
![14 new](https://user-images.githubusercontent.com/73130443/122738310-6609fc80-d271-11eb-90cd-9a0a19577aaa.PNG)
https://www.youtube.com/channel/UCYjRiR2FeyxpROu3laVWo_Q
![Capture](https://user-images.githubusercontent.com/73130443/101701940-cecd1c80-3a77-11eb-89b8-236d44dc3ffa.PNG)
I couldn't find an example for this so i edited this with the developer tools.
![16 new](https://user-images.githubusercontent.com/73130443/122739175-432c1800-d272-11eb-8252-24c0757436d5.PNG)
https://youtube.com/playlist?list=PL_7YUVmmp-LeUE2P6AbRKr4bRsr6p2ycs
qc3YsQeiS2.mp4
YT solution:
![Capture](https://user-images.githubusercontent.com/73130443/119913971-c6499f00-bf4e-11eb-98fa-6967036d6b29.PNG)
https://www.youtube.com/playlist?list=PLU_lUL8sj0nuNfOcOxuPOEFCuOEYCJ4ir (See video 15, the same scrolling problem happens here too.)
![Capture](https://user-images.githubusercontent.com/73130443/119915047-27727200-bf51-11eb-92c1-ec028813065a.PNG)
https://www.youtube.com/playlist?list=PLECWFmo8x9dZdduiItKmg1qS40vUB68Ir
PMkJxv0t2a.mp4
PMkJxv0t2a.mp4
YT solution:
![Playlist name](https://user-images.githubusercontent.com/73130443/119920238-85a45280-bf5b-11eb-984a-cb489904d94a.png)
Border.thumbnails.mp4
I couldn't find an example for this so i edited this with the developer tools.
![22](https://user-images.githubusercontent.com/73130443/122740044-1f1d0680-d273-11eb-97ee-d39e0ee948c3.PNG)
I couldn't find an example for this so i edited this with the developer tools.
23.mp4
nQkZYS5X4E.mp4
nQkZYS5X4E.mp4
lbOuDGtkAP.mp4
Additional context
In this post i have every section within Freetube covered.
Related #1336 (i created this one by accident i didnt know before that it belongs here)
![19 new](https://user-images.githubusercontent.com/73130443/122739562-a1f19180-d272-11eb-92fb-7dd4bbaf3614.PNG)
The text was updated successfully, but these errors were encountered: