Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Larger search/URL bar #5341

Open
3 tasks done
4yman-0 opened this issue Jun 26, 2024 · 6 comments · Fixed by #5348
Open
3 tasks done

[Feature Request]: Larger search/URL bar #5341

4yman-0 opened this issue Jun 26, 2024 · 6 comments · Fixed by #5348
Labels

Comments

@4yman-0
Copy link
Contributor

4yman-0 commented Jun 26, 2024

Guidelines

  • I have searched the issue tracker for open and closed issues that are similar to the feature request I want to file, without success.
  • I have searched the documentation for information that matches the description of the feature request I want to file, without success.
  • This issue contains only one feature request.

Problem Description

Space waste

Proposed Solution

Make search/URL bar (top of window) larger when there is enough space.

Alternatives Considered

only extend search bar when "Hide FreeTube Header Logo" is enabled

Issue Labels

visual improvement

Additional Information

There will be a lot of discussion ;)

@4yman-0 4yman-0 added the enhancement New feature or request label Jun 26, 2024
@efb4f5ff-1298-471a-8973-3d47447115dc
Copy link
Member

efb4f5ff-1298-471a-8973-3d47447115dc commented Jun 27, 2024

Space waste

IMO making something bigger because there is space unused does not sound like a good idea to me. This could also make the top bar appear overcrowded.

Like to hear opinions of the other members of the team

@4yman-0
Copy link
Contributor Author

4yman-0 commented Jun 29, 2024

Here's how it looks like in 2k using DevTools Device toolbar.
A max of 440px is not good for all devices, At least there will be some information (URL/search for example) rather than an empty background. We can also add spacing to make it look nice.
demo

@kommunarr
Copy link
Collaborator

kommunarr commented Jun 29, 2024

I'm not opposed to increasing the max size & better responsive design. For reference, the search bar in Gmail Web maxes out at 720px but shrinks if the viewport width doesn't suffice. YT maxes out at 640px.

@4yman-0
Copy link
Contributor Author

4yman-0 commented Jun 29, 2024

This is the window where increased the max to 720px and made grid repeat(3, 1fr)
Demo of large search bar

Here is the CSS:

@media only screen and (width >= 961px) {
    .topNav[data-v-284c500a] {
        display: grid;
        grid-template-columns: repeat(3, 1fr);
    }
}
.middle[data-v-284c500a] {
    flex: 1;
    max-inline-size: 720px;
}

@kommunarr
Copy link
Collaborator

That looks good from the screenshot. I can assign you if you want to open the PR for this one.

@4yman-0 4yman-0 mentioned this issue Jun 29, 2024
4 tasks
@4yman-0
Copy link
Contributor Author

4yman-0 commented Jun 29, 2024

It's in #5348 now!
but it has 1fr 720px 1fr instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants