Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bonfire Challenges #53

Closed
yaskyj opened this issue Jan 28, 2015 · 3 comments
Closed

Bonfire Challenges #53

yaskyj opened this issue Jan 28, 2015 · 3 comments

Comments

@yaskyj
Copy link

yaskyj commented Jan 28, 2015

I've had to reenter many of the challenges after pressing 'Take me to the next challenge.'
Also, on several of the challenges the test console output show errors (e.g. Unexpected Token) with no output concerning the test, but it still passes. I'll get a screenshot shot the next time it happens.
@terakilobyte
Copy link
Contributor

Thanks for the report. This is caused by the user not entering a test correctly. We'll work on hardening it up.

@yaskyj
Copy link
Author

yaskyj commented Jan 28, 2015

I don't believe I changed test text provided, but I could be wrong. But now that you mention that, if I change the test text I get the 'is not defined' error. It still gives the 'Take me to my next challenge' modal, but it will bring me back to the same challenge. If I do the same thing once more, it brings me to the next challenge.

@terakilobyte
Copy link
Contributor

Both of these issues have been addressed in pull request #55.

@yaskyj yaskyj mentioned this issue Mar 27, 2015
Closed
ValeraS pushed a commit to ValeraS/freeCodeCamp that referenced this issue Oct 12, 2018
@gforce2k5 @raisedadead
fix(challenges): fixed telephone number validator project (freeCodeCa…
2b034e2 
…mp#53)

fixed telephone number validator projects to show example telephone numbers on new lines

ISSUES CLOSED: freeCodeCamp#47
ValeraS pushed a commit to ValeraS/freeCodeCamp that referenced this issue Oct 12, 2018
@semantic-release-bot
chore(release): 3.0.0 [skip ci]
ebf0399 
# [3.0.0](freeCodeCamp/curriculum@v2.0.0...v3.0.0) (2018-06-29)

### Bug Fixes

* **challenge:** Fixed the typo for automatically ([freeCodeCamp#48](freeCodeCamp/curriculum#48)) ([dd046d6](freeCodeCamp/curriculum@dd046d6))
* **challenge:** Updated tests to avoid confusion ([freeCodeCamp#57](freeCodeCamp/curriculum#57)) ([7105507](freeCodeCamp/curriculum@7105507))
* **challenges:** change test for template literals challenge ([freeCodeCamp#37](freeCodeCamp/curriculum#37)) ([4b1c5eb](freeCodeCamp/curriculum@4b1c5eb))
* **challenges:** cherry pick pr 17664 & 17672 from main repo ([freeCodeCamp#52](freeCodeCamp/curriculum#52)) ([2375d0c](freeCodeCamp/curriculum@2375d0c))
* **challenges:** fixed telephone number validator project ([freeCodeCamp#53](freeCodeCamp/curriculum#53)) ([2b034e2](freeCodeCamp/curriculum@2b034e2)), closes [freeCodeCamp#47](freeCodeCamp/curriculum#47)
* **challenges:** fixed typo in css-grid.json ([freeCodeCamp#46](freeCodeCamp/curriculum#46)) ([e74192e](freeCodeCamp/curriculum@e74192e))
* **challenges:** grammar fix in css-grid auto-fit challenge ([freeCodeCamp#60](freeCodeCamp/curriculum#60)) ([a6a0266](freeCodeCamp/curriculum@a6a0266))
* **challenges:** Typo errors ([freeCodeCamp#39](freeCodeCamp/curriculum#39)) ([0c0702d](freeCodeCamp/curriculum@0c0702d))
* **challenges:** update regular expression that fails ([freeCodeCamp#56](freeCodeCamp/curriculum#56)) ([9fa5907](freeCodeCamp/curriculum@9fa5907)), closes [freeCodeCamp#55](freeCodeCamp/curriculum#55)

### BREAKING CHANGES

* **challenges:** None
moT01 pushed a commit that referenced this issue Jan 18, 2019
@edzebo @moT01
Fixed typo error on line #53 (#27944)
d78398a
@snyk-bot snyk-bot mentioned this issue Apr 10, 2022
Open
@snyk-bot snyk-bot mentioned this issue Jul 4, 2022
Open
@jcentino jcentino mentioned this issue Dec 5, 2022
Open
@jcentino jcentino mentioned this issue Dec 3, 2023
Open
@jcentino jcentino mentioned this issue Feb 5, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yaskyj @terakilobyte