Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a fix for this in #1648 #1687

Closed
markfirmware opened this issue Nov 23, 2020 · 1 comment
Closed

Added a fix for this in #1648 #1687

markfirmware opened this issue Nov 23, 2020 · 1 comment

Comments

@markfirmware
Copy link
Contributor

Thanks!

npm run build

still needs @types/chai and also @types/jest

also will need to publish to npm registry

Added a fix for this in #1648

Needs

npm i @types/chai
npm i @types/jest or npm i @types/mocha

https://github.com/markfirmware/audit/runs/1410602357?check_suite_focus=true

I’m seeing this work without @types/jest or @types/mocha, at least with the unmodified template. Is that correct? I’d like to simply let people install additional tools or swap the test runner if they so choose.

Originally posted by @drwpow in #1612 (comment)

@melissamcewen
Copy link
Contributor

Hi @markfirmware , this should have been fixed in 2.18, let us know if it's not working for you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants