Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error in sutime.py #40

Open
agrawal-b opened this issue Jun 22, 2020 · 2 comments
Open

error in sutime.py #40

agrawal-b opened this issue Jun 22, 2020 · 2 comments

Comments

@agrawal-b
Copy link

agrawal-b commented Jun 22, 2020

In sutime.py, there are certain jar files which are marked as required, and in jars those files have been updated and therefore now sutime.py is showing error, so to resolve this, i manually changed the names of those 'required jar files' in sutime.py.
can you please fix this issue, so that I do not need to manually change the names of jar files.

@Utkichaps
Copy link

Yeah for some reason the sutime.py file in the repo and the one after doing pip install don't match even though they are the same version. The code in the repo has the correct version of the java files

@kaushikacharya
Copy link

kaushikacharya commented Aug 13, 2020

Yeah for some reason the sutime.py file in the repo and the one after doing pip install don't match even though they are the same version. The code in the repo has the correct version of the java files

Version of java dependencies have been changed in this commit on 27th Oct 2018: 67c4798

https://pypi.org/project/sutime/#history
pip install version=0.2.0 is from Jan 11, 2017
(Though there have been few more releases, but the default version is 0.2.0)

Hence when we download dependencies using the updated pom.xml, there are mismatches regarding dependency jars.

Solution:
Either take the latest version from pypi or install from the local directory.

Regarding pom.xml
In few threads(e.g. #33), people have mentioned to copy pom.xml into sutime folder.
But in my opinion, that's not required.
Instead of that change:
mvn dependency:copy-dependencies -DoutputDirectory=./jars
to
mvn dependency:copy-dependencies -DoutputDirectory=./sutime/jars

Would request @FraBle to make this change.

@Utkichaps
Thanks for
a. #41 (comment) Showing visually the version differences in jars.
b. #41 (comment) Mentioning the changes needed to convert java.lang.String to python str.

These helped in making the code run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants