placeholder "APP": Expected string substitution

[vihai]

Hello,

After upgrading to 0.3.0 building results in:

$ ember build
Environment: development
cleaning up...
Build Error (broccoli-persistent-filter:Babel > [Babel: @embroider/macros]) in @embroider/macros/runtime.js

/home/vihai/src/kamaji-gui/@embroider/macros/runtime.js: @babel/template placeholder "APP": Expected string substitution

I am using Ember 4.1 without embroider (built with app.toTree()).
If I enable embroider (packages + compatBuild) it builds successfully.

Found this discussion:

embroider-build/embroider#1077

...but I didn't understand where the issue lies.

[jrjohnson]

That issue lies with any addon that has a pre 0.50 version of @embroider/macros. Many addons will need to be updated to @embroider/macros@v1. In our case that dependency comes from using ember-get-config. The best place to look for the issue is to run npm ls @embroider/macros and see what addons you have that need to be updated. I don't think there is anything that needs to be done here, but PRs welcome if I'm wrong. You're seeing this error in your app after the release here because of our dependency on ember-get-config.

[vihai]

Thank you very much and sorry for opening an issue that was not related to FortAwesome (I suspected that but the issue arose after updating just it). I hope this could be helpful to identify the scenario for others.

In my case the culprit is ember-power-select

[jrjohnson]

No worries, it's a messy issue and one I've been dealing with in our own apps all week. I'm glad you found your culprit! I'm going to close this, but feel free to re-open if it turns out there is something we need to do here.

[lcmen]

I've stumbled upon the same issue. Thank you @jrjohnson for describing details of the issue and providing npm ls command (TIL!) for tracking dependencies.

In my case the problem is caused by 2 addons:

• [email protected] relies on @embroider/[email protected] (via [email protected])
• [email protected] relies on @embroider/[email protected]

[bertdeblock]

fwiw, this addon could easily do without ember-get-config. It's only used in a component file, meaning you could just resolve the config instead. v1 of ember-get-config works significantly different than older versions and not really in a good way. It includes your config multiple times in the final build and the config you get from ember-get-config is not necessarily the same as the config an app author gets when doing import config from 'app/config/environment'.
Personally I would ditch ember-get-config here.

[jrjohnson]

@bertdeblock PR welcome! However getting the config from and add-on that may be consumed by other addons isn't as simple as importing it. That's the main advantage of ember-get-config, it handles the tricky part.

[bertdeblock]

getting the config from and add-on that may be consumed by other addons

I don't think the nesting of your addon matters if you do owner.resolveRegistration('config:environment').
I think that should always return the app's config.

Anyhow, ember-get-config v2 was just released.
At first glance, it seems to address the issues mentioned above.

EDIT: afaict, v2 still has (some of) the same issues.