svg_core local define func confused rjs parser

[3cp]

This call to local define func.

Font-Awesome/js-packages/@fortawesome/fontawesome-svg-core/index.es.js

Line 1607 in fc377a1

define('fa', icons);

It confused rjs parser which thinks it's a named AMD module definition. aurelia/cli#1013 (comment)

I know this is technically a rjs parser bug, but do you think it's a good idea to rename the internal define func to something like _define?

[tagliala]

Hi!

Thanks for being part of the Font Awesome Community.

Well, it makes sense.

Let's see what @robmadole thinks about this

[robmadole]

Yeah this is an easy fix. That function is private so changing it is a find/replace. Should be released in 5.7.0.

[3cp]

Thx very much!

[3cp]

Note this should be fixed in both umd (index.js) and esm build (index.es.js).

[robmadole]

Yep, we use Rollup.js to generate both of those from the same source file. They'll both be fixed. :)