Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pane header from scroll area in timeline view #367

Merged
merged 3 commits into from
May 21, 2021

Conversation

KenanYusuf
Copy link
Contributor

@KenanYusuf KenanYusuf commented May 20, 2021

Remove pane header from scroll area in timeline view (making it sticky)

Kapture.2021-05-20.at.11.45.05.mp4

@KenanYusuf KenanYusuf requested a review from andyrichardson May 20, 2021 12:25
Copy link
Collaborator

@andyrichardson andyrichardson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested out in cosmos - looks good!

Just noticed there's some weird scrolling on the schema panel (search bar should be locked in place) - isn't related to this PR but I'll put an issue together to get that fixed in a later release

Kapture 2021-05-20 at 13 39 00

</p>
</Pane.Item>
{event.data && (
<ScrollArea>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non blocking - how about

Suggested change
<ScrollArea>
<Pane.Body>

@KenanYusuf
Copy link
Contributor Author

KenanYusuf commented May 20, 2021

@andyrichardson fixed that here d594293?diff=split&w=1

Kapture.2021-05-20.at.14.25.35.mp4

@KenanYusuf KenanYusuf requested a review from andyrichardson May 20, 2021 13:34
@andyrichardson andyrichardson merged commit 88e2ede into master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants