Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pane titles to Timeline events, closes #239 #318

Merged
merged 2 commits into from
Oct 6, 2020

Conversation

bkonkle
Copy link
Contributor

@bkonkle bkonkle commented Oct 5, 2020

I went with the suggested styling - 12px right-justified text - within an h2 element for semantics, since the headings are h3 elements.

Screen Shot 2020-10-05 at 3 55 21 PM

@andyrichardson
Copy link
Collaborator

This is so subtle and yet makes a huge difference!

@andyrichardson
Copy link
Collaborator

Visual regression failing is expected (diffs are here).

Until we get something like chromatic, we have to update snapshots locally.

# Run visual regression
yarn visual-regression --watch

# Snapshots will fail - check the diff folder in `src/panel/__image_snapshots__`
# Assuming diffs are expected, hit 'u' to update snapshots 📸 

@bkonkle bkonkle merged commit cacfa55 into master Oct 6, 2020
@bkonkle bkonkle deleted the issue/239-timeline-pane-indicators branch October 6, 2020 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants