-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Request panel Schema #254
Conversation
clean up
start finished search add fixture
@sofiapoh I was wracking my brain all weekend on how we could get navigation to work on this in a devtools-esque way - you've killed it! I'll give this a try and code review today - so excited to get this merged! |
@@ -163,22 +162,6 @@ const ChildrenName = styled.span` | |||
font-size: 13px; | |||
`; | |||
|
|||
const Arrow = styled(ArrowIcon)` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you cool with us keeping styles/elements like this colocated?
If we're reusing the style/icon I'm down for pulling it out into a shared folder but for one-time use cases, it's much easier to colocate and then break out when reuse occurs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I reused this on on the Schema view, would you prefer I don't put this stuff in the shared folder just for that?
Quick todo for remaining blockers:
Once those are out of the way, let's get this released 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
This PR addresses #104 & #250: Adds a ✨ pretty ✨ view of the schema and a button to prettify your GraphQL request.
Fix #104
Fix #250
In terms of design, I've done my best to follow what we already have on the app + take inspiration from Firefox & Chrome devtools.
I've created some basic fixtures for some of the components but there are parts that could arguably be broken down further to better represents all the possible variations of the fields especially. I will also add the visual regression tests once I've received more feedback!
I've also started work on a simple search for types on another branch but this could be merged before this as I'm not 100% sure when I'll have time to complete it.Since opening the PR I also added a search on the schema as it was a nice and relatively simple addition :-) As it is now it's very simple type search, in future it would be nice to improve it to search for any values in the schema including fields.