Fix vertical overflow on timeline #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wgolledge
approved these changes
Apr 30, 2020
| overflow: hidden; | ||
| overflow-y: visible; | ||
| width: 100%; | ||
| box-sizing: border-box; |
There was a problem hiding this comment.
Not that it really matters, but I think alphabeticalising(?) css props can help keep them at least somewhat organised
There was a problem hiding this comment.
Would be cool if prettier could do this - do you have examples of repos that use this?
I can see the advantages - sometimes I group by type (e.g. color, positioning) but I'm not consistent with that.
There was a problem hiding this comment.
No concrete examples to hand - I don't think there's a defacto standard
I just found this post that was a fairly interesting read, and mentions stylelint-config-rational-order and stylelint-order which could be useful if using stylelint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Fix #177
Screenshots