Remove error tooltip for populate directives #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imranolas
commented
Apr 29, 2020
| @@ -61,7 +62,9 @@ export const RequestProvider: FC = ({ children }) => { | |||
| debugEvent.type === "update" && | |||
| isIntrospectionQuery(debugEvent.operation.query) | |||
| ) { | |||
| setSchema(buildClientSchema(debugEvent.data.value)); | |||
| setSchema( | |||
| appendPopulateDirective(buildClientSchema(debugEvent.data.value)) | |||
There was a problem hiding this comment.
Apply the transform on incoming schemas
| return extendSchema(schema, populateSchema); | ||
| } catch (err) { | ||
| if ( | ||
| err.message.startsWith( |
There was a problem hiding this comment.
If populate exists already extendSchema will throw. In this case we want to return the schema as is
andyrichardson
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Populate is a client side concept only and will throw an error when validated against the server side schema. This fix appends the populate directive to the client side schema to remove the error tooltips from any codemirror query panes.