From ea0d4c42a337777adc28c607068775e12ca823c8 Mon Sep 17 00:00:00 2001
From: Kadi Kraman <kadi.kraman@formidable.com>
Date: Mon, 18 Feb 2019 15:24:43 +0000
Subject: [PATCH 1/2] Revert "Replace 'compile' with 'implementation' (#242)"
This reverts commit 727945d69dc80079a6f7385e7f5b039f410b28d9.
---
android/build.gradle | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/android/build.gradle b/android/build.gradle
index 87cd461e..766251d2 100644
--- a/android/build.gradle
+++ b/android/build.gradle
@@ -34,6 +34,6 @@ repositories {
}
dependencies {
- implementation 'com.facebook.react:react-native:+'
- implementation "net.openid:appauth:0.7.1"
+ compile 'com.facebook.react:react-native:+'
+ compile "net.openid:appauth:0.7.1"
}
From c40949800c9fefae2bfe36253956741010c1459b Mon Sep 17 00:00:00 2001
From: Kadi Kraman <kadi.kraman@formidable.com>
Date: Mon, 18 Feb 2019 15:25:10 +0000
Subject: [PATCH 2/2] Add readme comment on patch package
---
README.md | 2 ++
1 file changed, 2 insertions(+)
diff --git a/README.md b/README.md
index 7d2942e4..45ecb3e5 100644
--- a/README.md
+++ b/README.md
@@ -314,6 +314,8 @@ class AppDelegate: UIApplicationDelegate, RNAppAuthAuthorizationFlowManager {
### Android Setup
+**Note:** for RN >= 0.57, you will get a warning about compile being obsolete. To get rid of this warning, use [patch-package](https://github.com/ds300/patch-package) to replace compile with implementation [as in this PR](https://github.com/FormidableLabs/react-native-app-auth/pull/242) - we're not deploying this right now, because it would break the build for RN < 57.
+
To setup the Android project, you need to perform two steps:
1. [Install Android support libraries](#install-android-support-libraries)