Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature edge-hanging corners #309

Merged

Conversation

hannesbrandt
Copy link
Contributor

This PR changes the domain-internal mesh creation. Now, quadrants that are corner neighbors across a coarser edge are detected and stored in the same format as all other corner-neighbor relations of the domain's mesh.
To achieve this fclaw2d_domain_new_{p4est,conn} call the new functions p4est_{wrap,mesh}_new_params, which were recently introduced in cburstedde/p4est#262 and cburstedde/p4est#268.

@scottaiton
Copy link
Member

scottaiton commented Jan 26, 2024

I tried this out on the dim-ind-test branch on scottaiton/forestclaw and the edgehanging_corners flag seems to be getting lost on refinement.

Specifically, when running the unit test:

src/patches/clawpatch/clawpatch.TEST --test-case="3d clawpatch ghost fill on cube with refinement coarse interior"

the mesh on the initial domain has the flag:

Screenshot 2024-01-26 at 12 18 10 PM

but after a call to domain_adapt, the mesh in the new domain does not have the flag:

Screenshot 2024-01-26 at 12 20 58 PM

@hannesbrandt
Copy link
Contributor Author

Good point, the mesh creation in wrap_adapt and wrap_partition was still calling mesh_new_ext. I addressed this issue in p4est as part of the recently merged PR cburstedde/p4est#283. Now, the mesh is created consistently using mesh_new_params with the mesh parameters as specified in the wrap parameters. If you could bump p4est to the current develop, I can adapt this PR to the changes.

@scottaiton scottaiton changed the base branch from develop to develop-3d February 5, 2024 19:52
@scottaiton
Copy link
Member

Updated to latest p4est in develop-3d. I also change this pull request to merge into develop-3d so I don't have to deal with two develop branches. If you can also remove the workaround in fclaw3d_patch_corner_neighbors, that would be appreciated.

@scottaiton scottaiton merged commit 388c6a6 into ForestClaw:develop-3d Feb 6, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants