Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Change how data is packed in tutorial #102

Merged
merged 1 commit into from
Sep 24, 2021
Merged

fix: Change how data is packed in tutorial #102

merged 1 commit into from
Sep 24, 2021

Conversation

chipbuster
Copy link
Contributor

Due to a bug, the code in getting_started trained a scalar model using
only part of the generated training data. This commit changes how
samples are packed into the data vector, which causes the code to
train a function from 5-vectors onto 2-vectors (as was intended).

Closes #101

Due to a bug, the code in getting_started trained a scalar model using
only part of the generated training data. This commit changes how
samples are packed into the `data` vector, which causes the code to
train a function from 5-vectors onto 2-vectors (as was intended).
Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@ToucheSir ToucheSir closed this Sep 24, 2021
@ToucheSir ToucheSir reopened this Sep 24, 2021
@ToucheSir ToucheSir merged commit 8d8e2b0 into FluxML:main Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Started example confusion
2 participants