Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

misc stuff for v0.15 release #2534

Merged
merged 22 commits into from
Dec 4, 2024
Merged

misc stuff for v0.15 release #2534

merged 22 commits into from
Dec 4, 2024

Conversation

CarloLucibello
Copy link
Member

@CarloLucibello CarloLucibello commented Dec 3, 2024 •
edited
Loading

TODO:

  • revisit gpu guide
  • reintegrate params docstring and show it in the docs
  • do a quick read of the whole documentation, see if something is odd
  • build the docs locally, see if we can make the compilation stricter
  • check if we can uncomment all the enzyme tests
  • see why code coverage is low

@CarloLucibello CarloLucibello added this to the v0.15 milestone Dec 3, 2024
@codecov Codecov
Copy link

codecov bot commented Dec 3, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 32.69%. Comparing base (f5d25e5) to head (1281b50).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/functor.jl 33.33% 2 Missing ⚠️
src/deprecations.jl 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##           master    #2534       +/-   ##
===========================================
+ Coverage   17.48%   32.69%   +15.20%     
===========================================
  Files          33       34        +1     
  Lines        1984     1976        -8     
===========================================
+ Hits          347      646      +299     
+ Misses       1637     1330      -307

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mcabbott
mcabbott reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@mcabbott mcabbott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing a bit, and especially for fighting CI.

I have some doc changes...

@CarloLucibello CarloLucibello merged commit 4fea1f9 into master Dec 4, 2024
5 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcabbott mcabbott mcabbott left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.15
Development

Successfully merging this pull request may close these issues.

broken image in the quickstart
2 participants
@CarloLucibello @mcabbott