#487, Image re encoding #669
Conversation
Can change image quality (1-100) image scaling down (1-10) and re-encoding as an image with different format (jpeg or png)
1. When selecting "change filename" option applying it and then changing the comment in the reply input it would not change the filename because of filename EditText that contains image's original name. So we have to update that EditText as well. 2. No options would be applied when Re-encode was no selected.
Since it's now handled correctly in a different place.
This sometimes causes the image to not be loaded at all. And we don't really need it here since this operation is pretty fast.
…png - disable quality seekbar Because png compression ignores the quality parameter. Fix wrong scaling.
Since we resized preview down to 128dp instead of the whole screen width it's now kinda uncomfortable that we have to click preview because it is small. So instead we use previewHolder for clicks listening that uses the whole width.
…ting quality to default)
|
It may be worth integrating #653 in with this. I'll take a look and submit a PR on your branch. |
|
Yeah, I thought about adding it in this task, but then I saw it already done. |
|
I've submitted a pull request on your 487 branch (https://github.com/K1rakishou/Clover/pull/1), and closed the PR for my EXIF changes (#653). |
Implement 150 functionality
|
Done. |
|
Great, really appreciate it. The rest of it looks good, but I'm not a reviewer on the project so I can't say much. |
|
Hey @K1rakishou, just letting you know I've merged your branch into my own multi-feature branch, if you want a build with this feature in it along with a bunch of other stuff I've added as well, you can find that here. I'm going to look at your other branches and I might add in the other stuff you've built. |
|
@Adamantcheese Yeah, I'm already using your build. Thanks for the merge, btw. You are free to merge my other branches (I would really appreciate it, actually) and if you find some questionable code just notify me I'll fix it. |
…ng them more convenient
|
A tiny improvement here. I made these buttons to have the maximum width they can take so it is more convenient to click them (you don't have to reach all the way to the left side)
|
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Closes #487
Added a new window with lots of options such as remove filename, remove metadata from image, change image checksum, re-encode image to different format (JPEG/PNG) change image quality and scale image down.