Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address verification #315

Closed
4 tasks
egonspace opened this issue Sep 3, 2021 · 1 comment
Closed
4 tasks

Address verification #315

egonspace opened this issue Sep 3, 2021 · 1 comment

Comments

@egonspace
Copy link

Summary

This PR(#298) has led us to treat address as string. In connection with this operation, the address string is verified at entry point as much as possible, and internally, the address is used without conversion. It is necessary to check address string verification throughout the code.

Especially, we should consider this TODO.

func (aa *AccAddress) UnmarshalJSON(data []byte) error {
	var s string
	err := json.Unmarshal(data, &s)
	if err != nil {
		return err
	}
	// TODO: address validation?
	*aa = AccAddress(s)
	return nil
}

Problem Definition

Proposal


For Admin Use

  • Not duplicate issue
  • Appropriate labels applied
  • Appropriate contributors tagged
  • Contributor assigned/self-assigned
@egonspace
Copy link
Author

There is no big problem, so close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant