Skip to content

Commit ab5fdbb

Browse files
authored
Merge pull request #141 from CosmWasm/minor_fixes
Minor fixes
2 parents 03bebe0 + 42f544f commit ab5fdbb

File tree

3 files changed

+9
-8
lines changed

3 files changed

+9
-8
lines changed

lcd_test/helpers.go

+3
Original file line numberDiff line numberDiff line change
@@ -382,6 +382,9 @@ func CreateAddr(name string, kb crkeys.Keybase) (sdk.AccAddress, string, error)
382382
seed string
383383
)
384384
info, seed, err = kb.CreateMnemonic(name, crkeys.English, keys.DefaultKeyPass, crkeys.Secp256k1)
385+
if err != nil {
386+
return nil, "", err
387+
}
385388
return sdk.AccAddress(info.GetPubKey().Address()), seed, err
386389
}
387390

x/wasm/client/rest/new_tx.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ func registerNewTxRoutes(cliCtx context.CLIContext, r *mux.Router) {
1919
type migrateContractReq struct {
2020
BaseReq rest.BaseReq `json:"base_req" yaml:"base_req"`
2121
Admin sdk.AccAddress `json:"admin,omitempty" yaml:"admin"`
22-
codeID uint64 `json:"code_id" yaml:"code_id"`
22+
CodeID uint64 `json:"code_id" yaml:"code_id"`
2323
MigrateMsg []byte `json:"migrate_msg,omitempty" yaml:"migrate_msg"`
2424
}
2525
type updateContractAdministrateReq struct {
@@ -84,7 +84,7 @@ func migrateContractHandlerFn(cliCtx context.CLIContext) http.HandlerFunc {
8484
msg := types.MsgMigrateContract{
8585
Sender: cliCtx.GetFromAddress(),
8686
Contract: contractAddress,
87-
Code: req.codeID,
87+
Code: req.CodeID,
8888
MigrateMsg: req.MigrateMsg,
8989
}
9090
if err = msg.ValidateBasic(); err != nil {

x/wasm/internal/keeper/keeper.go

+4-6
Original file line numberDiff line numberDiff line change
@@ -87,11 +87,6 @@ func (k Keeper) Create(ctx sdk.Context, creator sdk.AccAddress, wasmCode []byte,
8787
return codeID, nil
8888
}
8989

90-
// returns true when simulation mode used by gas=auto queries
91-
func isSimulationMode(ctx sdk.Context) bool {
92-
return ctx.GasMeter().Limit() == 0 && ctx.BlockHeight() != 0
93-
}
94-
9590
// Instantiate creates an instance of a WASM contract
9691
func (k Keeper) Instantiate(ctx sdk.Context, codeID uint64, creator, admin sdk.AccAddress, initMsg []byte, label string, deposit sdk.Coins) (sdk.AccAddress, error) {
9792
// create contract address
@@ -371,7 +366,10 @@ func (k Keeper) setContractState(ctx sdk.Context, contractAddress sdk.AccAddress
371366
prefixStoreKey := types.GetContractStorePrefixKey(contractAddress)
372367
prefixStore := prefix.NewStore(ctx.KVStore(k.storeKey), prefixStoreKey)
373368
for _, model := range models {
374-
prefixStore.Set([]byte(model.Key), []byte(model.Value))
369+
if model.Value == nil {
370+
model.Value = []byte{}
371+
}
372+
prefixStore.Set(model.Key, model.Value)
375373
}
376374
}
377375

0 commit comments

Comments
 (0)